Fixed conversion of LocalDateTime and LocalTime to String in Bulk Copy#1640
Merged
lilgreenbird merged 5 commits intomicrosoft:devfrom Nov 5, 2021
Merged
Fixed conversion of LocalDateTime and LocalTime to String in Bulk Copy#1640lilgreenbird merged 5 commits intomicrosoft:devfrom
lilgreenbird merged 5 commits intomicrosoft:devfrom
Conversation
David-Engel
reviewed
Aug 20, 2021
Collaborator
David-Engel
left a comment
David-Engel
left a comment
There was a problem hiding this comment.
We should also extend testBulkCopyDateTimePrecision added in #1559 to include data that this fix is covering.
AbductedNoah
previously approved these changes
Oct 28, 2021
David-Engel
approved these changes
Nov 5, 2021
lilgreenbird
approved these changes
Nov 5, 2021
Contributor
|
hi @joechu1 |
lilgreenbird
changed the title
lilgreenbird
pushed a commit
to lilgreenbird/mssql-jdbc
that referenced
this pull request
Dec 1, 2021
…icrosoft#1640) * Use DateTimeFormatter to convert LocalDateTime and LocalTime to String * Streamlining toString calls and adding tests * Changed string pattern to match expected precision * Formatting * Formatting Co-authored-by: Joe Chu <[email protected]> Co-authored-by: David Engel <[email protected]>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When writing a LocalDateTime with bulk copy, the driver may return an error when second-of-minute and nano-of-second is 0:
When time units to the right of the minute are all 0's, the LocalDateTime.toString() will simplify the string format to uuuu-MM-dd'T'HH:mm, which SQL Server is not able to process due to the missing seconds. This PR changes the string conversion to use the DateTimeFormatter and ensures that it includes the necessary padding.
For example:
Note that this is very similar to PR #1485.