Skip to content

Remove Java 9-specific class references from the Java 8 jar#1626

Merged
David-Engel merged 4 commits intomicrosoft:devfrom
David-Engel:java8
Jul 31, 2021
Merged

Remove Java 9-specific class references from the Java 8 jar#1626
David-Engel merged 4 commits intomicrosoft:devfrom
David-Engel:java8

Conversation

@David-Engel
Copy link
Copy Markdown
Collaborator

No description provided.

lilgreenbird
lilgreenbird previously approved these changes Jul 30, 2021
@cheenamalhotra
Copy link
Copy Markdown
Member

cheenamalhotra commented Jul 30, 2021

We need to be able to build with JDK 1.8 - it seems there's an override in SqlServerDatabaseMetadata that should be split in a separate *43 class respectively and excluded for jre8 build.

    @Override
    public boolean supportsSharding() throws SQLException {
        DriverJDBCVersion.checkSupportsJDBC43();
        checkClosed();
        return false;
    }

Comment thread pom.xml
Comment thread pom.xml
@David-Engel
Copy link
Copy Markdown
Collaborator Author

We need to be able to build with JDK 1.8 - it seems there's an override in SqlServerDatabaseMetadata that should be split in a separate *43 class respectively and excluded for jre8 build.

@cheenamalhotra I saw that when I tried building with JDK 1.8. Since that class wasn't mentioned in the original issue, I thought I could skip it and hope the reference checking that is happening at load time in their scenario is not evaluating overrides.

@cheenamalhotra
Copy link
Copy Markdown
Member

Yes, it's resolved on runtime as Java 8 doesn't have the API to override so it ignores but we should consider Eclipse environment errors too, and exclude all that contributes to errors. I would say this code is still present that's not applicable to jre8 and could be removed with no risk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants