Fix | Remove clientKeyPassword from memory#1428
Merged
ulvii merged 2 commits intomicrosoft:devfrom Oct 9, 2020
Merged
Conversation
ulvii
approved these changes
Sep 28, 2020
rene-ye
approved these changes
Oct 2, 2020
lilgreenbird
approved these changes
Oct 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From PenTest results.
As with other passwords that have been removed from memory, I temporarily add it back for XA connections because XA connections create two connections (one for control connection, one for actual connections), but the outcome is the same in that this password will not remain in memory after the connection has been established.