Feature | Accept connected sockets from custom socket factory#1420
Merged
peterbae merged 2 commits intomicrosoft:devfrom Sep 9, 2020
Merged
Feature | Accept connected sockets from custom socket factory#1420peterbae merged 2 commits intomicrosoft:devfrom
peterbae merged 2 commits intomicrosoft:devfrom
Conversation
3 tasks
ulvii
approved these changes
Sep 8, 2020
rene-ye
approved these changes
Sep 9, 2020
lilgreenbird
approved these changes
Sep 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the driver is assuming the socket created from the socket factory is not connected, but there may be custom implementations that return a socket that's already connected. This change handles this case.
Fixes #1382.