-
Notifications
You must be signed in to change notification settings - Fork 467
Upgrading to new Key Vault (and MSAL) libraries #1413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
168 commits
Select commit
Hold shift + click to select a range
c97b863
Fix AEv2 tests exclude for reqExternalSetup and cleanup (#1247)
lilgreenbird 54b5a19
Fix | Add null check for getObject() with LocalTime and LocalDate (#1…
peterbae 672b7d6
added all AKV tests to use reqExternalSetup tag so they will be skipp…
lilgreenbird 3c3331b
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird e2c5640
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird aad6966
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird 92bf04c
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird 3ba5ab7
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird d20823d
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird 4cc959f
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird 7b301f8
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird 56bcf13
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird 744e0ca
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird df8fd41
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird 652e68b
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird 53736db
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird 9ba6a42
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird 6d156f7
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird e08ffe5
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird 6b6cab2
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird f4555d6
First pass at porting to new Key Vault
JonathanGiles c202590
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird 0515d4b
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird 892eb2b
Everything now compiles, but I'm sure there are numerous bugs, and te…
JonathanGiles 088d2f7
Beginning to re-enable some disabled unit tests
JonathanGiles 30e7fdf
Add requirement for a tenant ID to be set to run tests
JonathanGiles 2c63b58
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird 2d62262
Minor tidy ups
JonathanGiles a6b75cd
Upgrade gradle file to include equivalent dependencies as in pom.xml,…
JonathanGiles 78aa941
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird 90e99cd
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird 5e37322
add -DtenantID=$(tenantID)
peterbae 1df8828
Merge pull request #1 from peterbae/keyvault-upgrade
JonathanGiles da1004b
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird 8c9a944
Updating APIs to propagate tenantId. Still I am sure the tests will f…
JonathanGiles f7f12d9
Merge branch 'keyvault-upgrade' of github.com:JonathanGiles/mssql-jdb…
JonathanGiles cc0ac7f
Updating method call to add missing tenantId
JonathanGiles 86fc00c
Wiring in vaultBaseUrl env var lookup for Key Vault
JonathanGiles 8fec202
Debugging key path format (hopefully)
JonathanGiles 9f44f0f
Clean up algorithm code
JonathanGiles dab428f
Adding validation for vaultBaseURL
JonathanGiles 9ca1284
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird c67d8ed
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird 1d0a4ad
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird 398c2d8
Fixes for Key and Crypto client
srnagar 1b363f7
Merge pull request #2 from srnagar/keyvault-upgrade
JonathanGiles 948939f
Merge from master
srnagar 6d014b5
Merge pull request #3 from srnagar/keyvault-upgrade
JonathanGiles dcf2f79
Fix compilation errors after merging from master
srnagar 62a83e4
Merge pull request #4 from srnagar/keyvault-upgrade
JonathanGiles 73d160f
Add tenantID to pipeline yml
srnagar fba2a23
Merge pull request #5 from srnagar/keyvault-upgrade
JonathanGiles 54642ab
Merge branch 'keyvault-upgrade' of https://github.com/JonathanGiles/m…
lilgreenbird f006a63
Fix unit test
srnagar b2db031
Merge pull request #6 from srnagar/keyvault-upgrade
JonathanGiles 96e32f4
Merge branch 'keyvault-upgrade' of https://github.com/JonathanGiles/m…
lilgreenbird 47a7b94
Address PR comments
srnagar 9b1cac0
Merge remote-tracking branch 'upstream/dev' into keyvault-upgrade
srnagar fcf327e
Merge pull request #7 from srnagar/keyvault-upgrade
JonathanGiles 23b7f6a
Remove tenant Id and fix adal issues
srnagar 4121bc5
Merge pull request #8 from srnagar/keyvault-upgrade
JonathanGiles bca00d2
Merge branch 'keyvault-upgrade' of https://github.com/JonathanGiles/m…
lilgreenbird 37c676d
Fix test failures
srnagar 8e8517b
Merge pull request #9 from srnagar/keyvault-upgrade
JonathanGiles b2eb9cb
Merge branch 'keyvault-upgrade' of https://github.com/JonathanGiles/m…
lilgreenbird ee3b5c8
Use cached key and crypto clients
srnagar 48c6dac
Merge pull request #10 from srnagar/keyvault-upgrade
JonathanGiles 6baad02
Update license header and cleanup pipeline builder
srnagar a053426
Merge pull request #11 from srnagar/keyvault-upgrade
JonathanGiles 0a3cb0f
Fix unit tests
srnagar 1bf984a
Merge branch 'keyvault-upgrade' of https://github.com/JonathanGiles/m…
lilgreenbird 684ecce
Merge pull request #12 from srnagar/keyvault-upgrade
JonathanGiles 62ab01a
Merge branch 'keyvault-upgrade' of https://github.com/JonathanGiles/m…
lilgreenbird ef464f9
Merge remote-tracking branch 'upstream/dev' into msal
lilgreenbird e4206e1
Java 8 compatibility
srnagar d7c2305
Merge pull request #13 from srnagar/keyvault-upgrade
JonathanGiles fccc5b7
Merge branch 'keyvault-upgrade' of https://github.com/JonathanGiles/m…
lilgreenbird be1d739
Change Set.of to Collections.singleton()
srnagar 1423d93
Remote tenant id from JDBC tests
srnagar e077ffe
Merge pull request #14 from srnagar/keyvault-upgrade
JonathanGiles 9ad6edc
Merge branch 'keyvault-upgrade' of https://github.com/JonathanGiles/m…
lilgreenbird f749361
Merge remote-tracking branch 'upstream/dev' into keyvault-upgrade
srnagar b08233c
Merge from dev
srnagar 49b802e
Merge pull request #15 from srnagar/keyvault-upgrade
JonathanGiles c7bfe70
Merge branch 'keyvault-upgrade' of https://github.com/JonathanGiles/m…
lilgreenbird e743268
Merge remote-tracking branch 'upstream/dev' into msal
lilgreenbird c2622e4
Merge remote-tracking branch 'upstream/dev' into keyvault-upgrade
srnagar ffd6a74
Merge branch 'keyvault-upgrade' of https://github.com/srnagar/mssql-j…
lilgreenbird 90ccde0
Remove tenant id and reverse null checks
srnagar f1b1dfb
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird d7c44b5
Fix compile errors
srnagar fe09531
Remove tenant id from pipelines yml
srnagar 15db9cd
Merge branch 'keyvault-upgrade' of https://github.com/srnagar/mssql-j…
lilgreenbird 8d1f462
Update javadoc
srnagar 2251550
Merge branch 'keyvault-upgrade' of https://github.com/srnagar/mssql-j…
lilgreenbird fd98376
Merge remote-tracking branch 'upstream/dev' into msal
lilgreenbird 04c05bd
formatting
lilgreenbird 53d4408
Merge remote-tracking branch 'upstream/dev' into msal
lilgreenbird 5bc6755
Merge pull request #1 from lilgreenbird/msal
srnagar 3303022
Update src/main/java/com/microsoft/sqlserver/jdbc/ScopeTokenCache.java
lilgreenbird d9bad87
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird d24dbff
Merge remote-tracking branch 'upstream/dev' into msal
lilgreenbird 59aebe6
exception handling and removed unnecessary public apis
lilgreenbird 6b2f1a2
added header
lilgreenbird 2e6180f
merged
lilgreenbird c7cd598
Merge pull request #2 from lilgreenbird/msal
srnagar 4ef6a37
more updates
lilgreenbird a0644be
update
lilgreenbird 042ade5
Merge pull request #3 from lilgreenbird/msal
srnagar abdf38d
merged
lilgreenbird 573dfb9
Merge branch 'keyvault-upgrade' of https://github.com/srnagar/mssql-j…
lilgreenbird 48fbe2c
Merge remote-tracking branch 'upstream/dev' into msal
lilgreenbird a2e50b9
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird 7ff97de
enable ADintegrated tests for non-windows
lilgreenbird 887d9b1
Merge remote-tracking branch 'upstream/dev' into msal
lilgreenbird 4a8b4f3
Merge remote-tracking branch 'upstream/dev' into msal
lilgreenbird 7cae3b4
fixed user test for kerberos
lilgreenbird c180e5f
Update to latest version of KV and Identity
srnagar d0186a9
Merge branch 'keyvault-upgrade' of https://github.com/srnagar/mssql-j…
lilgreenbird 4c9b627
Merge remote-tracking branch 'upstream/dev' into msal
lilgreenbird e863c05
user name check
lilgreenbird 43060f9
Bring back deprecated constructors
srnagar c8c5a29
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird 1550a97
Merge branch 'keyvault-upgrade' of https://github.com/srnagar/mssql-j…
lilgreenbird f4825db
Resolve merge conflicts
srnagar b85e3c2
merged
lilgreenbird 7d4274f
Add auth callback tests
srnagar 2a92d4d
Merge branch 'keyvault-upgrade' of https://github.com/srnagar/mssql-j…
lilgreenbird 61b787f
Merge remote-tracking branch 'upstream/dev' into msal
lilgreenbird 360a8d4
lib conflict
lilgreenbird d76368a
Merge remote-tracking branch 'upstream/dev' into dev
lilgreenbird e5aafd3
Merge branch 'dev' of https://github.com/lilgreenbird/mssql-jdbc into…
lilgreenbird 1108103
merged
lilgreenbird 950677f
merged
lilgreenbird 12f2da9
back to prev lib version
lilgreenbird 2b3ccd6
fix
lilgreenbird 497f1be
merged
lilgreenbird 972f95c
Merge branch 'msal' of https://github.com/lilgreenbird/mssql-jdbc int…
lilgreenbird 216d77a
fixed
lilgreenbird 791e2b6
update
lilgreenbird a711913
merged
lilgreenbird 122e408
Merge pull request #4 from lilgreenbird/msal
srnagar b4799ca
Remove hardcoded version and package name
srnagar c722d34
clean and exclude lib
lilgreenbird 9c28d98
Add code comments and javadoc
srnagar 338f480
Merge remote-tracking branch 'upstream/dev' into msal
lilgreenbird 9010b5f
Merge branch 'keyvault-upgrade' of https://github.com/srnagar/mssql-j…
lilgreenbird da75dcc
updates
lilgreenbird 0d509af
Merge pull request #5 from lilgreenbird/msal
srnagar 33c276a
formatting and reive updates
lilgreenbird ad27b88
Rebase from remote branch
srnagar 0899333
Update tests
srnagar a4a99ec
Rebase from remote branch
srnagar ca36f34
Update pom.xml
srnagar 2bf012b
Merge branch 'keyvault-upgrade' of https://github.com/srnagar/mssql-j…
lilgreenbird 9e38cc3
Merge pull request #6 from lilgreenbird/msal
srnagar 7a035c6
review updates
lilgreenbird a630897
catch exception
lilgreenbird 48cacfa
Merge pull request #7 from lilgreenbird/msal
srnagar 793207e
added test for token credential
lilgreenbird 1a22d78
Merge pull request #8 from lilgreenbird/msal
srnagar 8f483e2
added tenantID property
lilgreenbird 9fbc989
Merge remote-tracking branch 'upstream/dev' into msal
lilgreenbird a011ea7
Merge pull request #9 from lilgreenbird/msal
srnagar d8f20da
updated error msgs
lilgreenbird c6d444c
update version
lilgreenbird f7aeb12
Update README.md
lilgreenbird 61ee2d4
Merge pull request #10 from lilgreenbird/msal
srnagar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
90 changes: 0 additions & 90 deletions
90
src/main/java/com/microsoft/sqlserver/jdbc/KeyVaultCredential.java
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.