Fix spatial datatypes cast error when AE is enabled#1353
Merged
peterbae merged 1 commit intomicrosoft:devfrom Jun 10, 2020
Merged
Fix spatial datatypes cast error when AE is enabled#1353peterbae merged 1 commit intomicrosoft:devfrom
peterbae merged 1 commit intomicrosoft:devfrom
Conversation
lilgreenbird
approved these changes
Jun 5, 2020
rene-ye
approved these changes
Jun 9, 2020
ulvii
approved these changes
Jun 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just needed the same treatment as in dtv.java:
mssql-jdbc/src/main/java/com/microsoft/sqlserver/jdbc/dtv.java
Line 1609 in dbb3547
In the case where the javaType is String but the JDBCType is Geometry or Geography, we need to handle the data a bit differently. Tests with AE enabled passed, and Maven test passed as well.