Append server name from connection string to error message#1311
Merged
lilgreenbird merged 16 commits intomicrosoft:devfrom Apr 29, 2020
Merged
Append server name from connection string to error message#1311lilgreenbird merged 16 commits intomicrosoft:devfrom
lilgreenbird merged 16 commits intomicrosoft:devfrom
Conversation
…ed by default (microsoft#1254) * skip AKV test properly * removed enclave properties string to failed errors as enclave tests could be skipped
Codecov Report
@@ Coverage Diff @@
## dev #1311 +/- ##
============================================
- Coverage 58.42% 52.95% -5.48%
+ Complexity 3826 3492 -334
============================================
Files 133 133
Lines 30096 30096
Branches 4979 4979
============================================
- Hits 17584 15936 -1648
- Misses 10077 11870 +1793
+ Partials 2435 2290 -145 Continue to review full report at Codecov.
|
peterbae
reviewed
Apr 15, 2020
Contributor
|
Can you add tests to this (if it's feasible) so that the test shows what the error message would look like instead? |
peterbae
previously approved these changes
Apr 23, 2020
ulvii
reviewed
Apr 23, 2020
peterbae
approved these changes
Apr 28, 2020
ulvii
approved these changes
Apr 28, 2020
rene-ye
approved these changes
Apr 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if server name in connection string is different from connect server then append server name to error message thrown