Adding Delayed Durability#1310
Merged
ulvii merged 2 commits intomicrosoft:devfrom May 1, 2020
Merged
Conversation
Adding an overload of commit() to support delayed durability
Contributor
|
Hi @dbrownems, thank you for your contribution. I think adding an option to enable delayed durability could be useful to some users. Could you modify the commit() method so that it calls the commit(false) method to remove some code duplication here? |
Contributor
Author
|
Do you think it needs to be added to ISqlServerConnection and to the proxy type too? Also I can't get the project to build. Are there any better instructions? I tried from the commandline and various IDEs, but no luck. |
Contributor
|
We have instructions for building the JAR files using maven in our README file (let us know if you're stuck on one of the steps). This won't need to be added to ISqlServerConnection or the proxy type. |
peterbae
approved these changes
Apr 29, 2020
ulvii
approved these changes
Apr 29, 2020
rene-ye
approved these changes
Apr 30, 2020
Contributor
|
Thanks for contribution @dbrownems |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding an overload of commit() to support delayed durability. Fixed compilation error. Didn't add method to ISQLServerConnection interface. Not sure if that is desirable.