Skip to content

Feature | Added support for authentication to Azure Key Vault using Managed Identity#1286

Merged
ulvii merged 63 commits intomicrosoft:devfrom
lilgreenbird:msi
Apr 1, 2020
Merged

Feature | Added support for authentication to Azure Key Vault using Managed Identity#1286
ulvii merged 63 commits intomicrosoft:devfrom
lilgreenbird:msi

Conversation

@lilgreenbird
Copy link
Copy Markdown
Contributor

@lilgreenbird lilgreenbird commented Mar 18, 2020 •
edited
Loading

addresses issue 1069.

New connection properties added to support to authenticate to AKV using Managed Identities:

KeyStoreAuthentication=KeyVaultClientSecret|KeyVaultManagedIdentity
keyStorePrincipalId=<valid Azure Directory Application Client ID>

and use existing connection property:

keyStoreSecret= <key store secret>

lilgreenbird and others added 30 commits February 5, 2020 11:03
@lilgreenbird
Fix AEv2 tests exclude for reqExternalSetup and cleanup (microsoft#1247)
c97b863
@peterbae
Fix | Add null check for getObject() with LocalTime and LocalDate (mi…
54b5a19 
…crosoft#1250)
@lilgreenbird
added all AKV tests to use reqExternalSetup tag so they will be skipp…
672b7d6 
…ed by default (microsoft#1254)

* skip AKV test properly

* removed enclave properties string to failed errors as enclave tests could be skipped
@lilgreenbird
msi for akv
32c21f5
@lilgreenbird
Merge remote-tracking branch 'upstream/dev' into msi
b706fb3
@lilgreenbird
msi tests
9e368a5
@lilgreenbird
added new props for AKV with MSI
28bb1ee
@lilgreenbird
fixed formatting
b75ebab
@lilgreenbird
fixed formatting
3ce5ad8
@lilgreenbird
fixed formatting
3a9db37
@lilgreenbird
fixed formatting
5ba6881
@lilgreenbird
test fixes
95948c1
@lilgreenbird
update connection property names
beac701
@lilgreenbird
updated tests
86b14ee
@lilgreenbird
removed unused
48801af
@lilgreenbird
ks registration
7cf8a68
@lilgreenbird
debug
a64c995
@lilgreenbird
debug
7b013e9
@lilgreenbird
debug
395790f
@lilgreenbird
debug
5bb4313
@lilgreenbird
remove debug
065a0f0
@lilgreenbird
remove debug
9ed54ef
@lilgreenbird
AE connectionstring
48369bc
@lilgreenbird
more tests
7a43bfd
@lilgreenbird
more tests
c2120a3
@lilgreenbird
more tests
6dad2e4
@lilgreenbird
fixed typo
564350d
@lilgreenbird
updated tests
855b71b
@lilgreenbird
null check
355729e
@lilgreenbird
javadoc
6ee6aa2
rene-ye
rene-ye reviewed Mar 31, 2020
View reviewed changes
Comment thread src/main/java/com/microsoft/sqlserver/jdbc/SQLServerSecurityUtility.java Outdated
ulvii
ulvii reviewed Mar 31, 2020
View reviewed changes
Comment thread src/main/java/com/microsoft/sqlserver/jdbc/ISQLServerDataSource.java Outdated
ulvii
ulvii reviewed Mar 31, 2020
View reviewed changes
Comment thread src/main/java/com/microsoft/sqlserver/jdbc/SQLServerConnection.java Outdated
ulvii
ulvii reviewed Mar 31, 2020
View reviewed changes
Comment thread src/main/java/com/microsoft/sqlserver/jdbc/SQLServerConnection.java Outdated
ulvii
ulvii reviewed Mar 31, 2020
View reviewed changes
Comment thread src/test/java/com/microsoft/sqlserver/jdbc/AlwaysEncrypted/MSITest.java Outdated
ulvii
ulvii reviewed Mar 31, 2020
View reviewed changes
Comment thread src/test/java/com/microsoft/sqlserver/jdbc/AlwaysEncrypted/MSITest.java Outdated
ulvii
ulvii reviewed Mar 31, 2020
View reviewed changes
Comment thread src/test/java/com/microsoft/sqlserver/jdbc/AlwaysEncrypted/MSITest.java Outdated
ulvii
ulvii reviewed Mar 31, 2020
View reviewed changes
Comment thread src/test/java/com/microsoft/sqlserver/jdbc/AlwaysEncrypted/MSITest.java
@ulvii ulvii added this to the 8.3.0 milestone Mar 31, 2020
rene-ye
rene-ye reviewed Mar 31, 2020
View reviewed changes
Comment thread src/main/java/com/microsoft/sqlserver/jdbc/SQLServerSecurityUtility.java
ulvii
ulvii reviewed Mar 31, 2020
View reviewed changes
Comment thread src/test/java/com/microsoft/sqlserver/jdbc/AlwaysEncrypted/MSITest.java
ulvii
ulvii reviewed Mar 31, 2020
View reviewed changes
Comment thread src/test/java/com/microsoft/sqlserver/jdbc/AlwaysEncrypted/MSITest.java Outdated
ulvii
ulvii reviewed Mar 31, 2020
View reviewed changes
Comment thread src/test/java/com/microsoft/sqlserver/jdbc/AlwaysEncrypted/MSITest.java Outdated
@ulvii ulvii merged commit 6a483b0 into microsoft:dev Apr 1, 2020
@ulvii ulvii changed the title Add support to use Managed Identity for AKV authentication Feature | Added support for authentication to Azure Key Vault using Managed Identity Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peterbae peterbae Awaiting requested review from peterbae

2 more reviewers

@rene-ye rene-ye rene-ye left review comments

@ulvii ulvii ulvii approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

8.3.0

Development

Successfully merging this pull request may close these issues.

4 participants

@lilgreenbird @rene-ye @ulvii @peterbae