Feature | Added caching for Always Encrypted with secure enclaves#1189
Merged
ulvii merged 26 commits intomicrosoft:devfrom Dec 7, 2019
Merged
Feature | Added caching for Always Encrypted with secure enclaves#1189ulvii merged 26 commits intomicrosoft:devfrom
ulvii merged 26 commits intomicrosoft:devfrom
Conversation
…Regression # Conflicts: # src/main/java/com/microsoft/sqlserver/jdbc/SQLServerConnection.java # src/main/java/com/microsoft/sqlserver/jdbc/SQLServerVSMEnclaveProvider.java
| } | ||
|
|
||
| @Override | ||
| public void invalidateEnclaveSession() { |
Contributor
There was a problem hiding this comment.
this still isn't used, when do we need to call this?
| if (null == rs) { | ||
| // No results. Meaning no parameter. | ||
| // Should never happen. | ||
| return enclaveRequestedCEKs; |
Contributor
There was a problem hiding this comment.
should we log something?
| } | ||
|
|
||
|
|
||
| class JWTCertificateEntry { |
Contributor
There was a problem hiding this comment.
general comment (applies elsewhere too)
Can we add comments to these classes? I know they're not public so no need for javadocs, but would be nice to have some descriptions on what these are
lilgreenbird
reviewed
Dec 3, 2019
ulvii
reviewed
Dec 4, 2019
ulvii
reviewed
Dec 4, 2019
lilgreenbird
reviewed
Dec 4, 2019
ulvii
reviewed
Dec 4, 2019
ulvii
changed the title
peterbae
reviewed
Dec 4, 2019
peterbae
reviewed
Dec 4, 2019
peterbae
reviewed
Dec 4, 2019
peterbae
reviewed
Dec 4, 2019
ulvii
approved these changes
Dec 7, 2019
ulvii
pushed a commit
that referenced
this pull request
Mar 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the following