Skip to content

Change | Updated ISQLServerBulkData APIs to throw SQLException#1187

Merged
ulvii merged 1 commit intomicrosoft:devfrom
ulvii:issue1185
Nov 22, 2019
Merged

Change | Updated ISQLServerBulkData APIs to throw SQLException#1187
ulvii merged 1 commit intomicrosoft:devfrom
ulvii:issue1185

Conversation

@ulvii
Copy link
Copy Markdown
Contributor

@ulvii ulvii commented Nov 19, 2019

The PR also updates Bulk Copy tests to use ISQLServerBulkData instead of ISQLServerBulkRecord.

@ulvii ulvii mentioned this pull request Nov 19, 2019
Closed
@ulvii ulvii added this to the 8.1.1 milestone Nov 20, 2019
@codecov-io
Copy link
Copy Markdown

codecov-io commented Nov 20, 2019 •
edited
Loading

Codecov Report

Merging #1187 into dev will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #1187      +/-   ##
============================================
- Coverage     55.86%   55.74%   -0.12%     
+ Complexity     3551     3541      -10     
============================================
  Files           130      130              
  Lines         29332    29332              
  Branches       4855     4855              
============================================
- Hits          16385    16351      -34     
- Misses        10625    10657      +32     
- Partials       2322     2324       +2
Impacted Files Coverage Δ Complexity Δ
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 45.05% <0%> (-2.2%) 15% <0%> (-1%)
...m/microsoft/sqlserver/jdbc/SQLServerException.java 74.28% <0%> (-2.15%) 34% <0%> (-2%)
...n/java/com/microsoft/sqlserver/jdbc/tdsparser.java 73.55% <0%> (-1.66%) 0% <0%> (ø)
...a/com/microsoft/sqlserver/jdbc/PLPInputStream.java 59.76% <0%> (-1.19%) 34% <0%> (-1%)
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 47.73% <0%> (-0.87%) 111% <0%> (-2%)
...rc/main/java/com/microsoft/sqlserver/jdbc/TVP.java 43.72% <0%> (-0.81%) 26% <0%> (ø)
...ft/sqlserver/jdbc/SQLServerVSMEnclaveProvider.java 80.39% <0%> (-0.34%) 27% <0%> (ø)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 61.87% <0%> (-0.27%) 0% <0%> (ø)
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 39% <0%> (-0.22%) 43% <0%> (-1%)
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 68.88% <0%> (-0.18%) 0% <0%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3eb3f12...b8dc83a. Read the comment docs.

@ulvii ulvii merged commit 3ebc3f9 into microsoft:dev Nov 22, 2019
@ulvii ulvii deleted the issue1185 branch November 22, 2019 22:20
ulvii added a commit that referenced this pull request Mar 3, 2020
@ulvii
Fix | Update ISQLServerBulkData to throw SQLException (#1187)
5ee2092
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@rene-ye rene-ye rene-ye approved these changes

@lilgreenbird lilgreenbird lilgreenbird approved these changes

@peterbae peterbae peterbae approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

8.1.1

Development

Successfully merging this pull request may close these issues.

5 participants

@ulvii @codecov-io @rene-ye @lilgreenbird @peterbae