Skip to content

more AE tests and updated AE properties to not read from env variable#1186

Merged
lilgreenbird merged 65 commits intomicrosoft:devfrom
lilgreenbird:aetests
Nov 29, 2019
Merged

more AE tests and updated AE properties to not read from env variable#1186
lilgreenbird merged 65 commits intomicrosoft:devfrom
lilgreenbird:aetests

Conversation

@lilgreenbird
Copy link
Copy Markdown
Contributor

@lilgreenbird lilgreenbird commented Nov 19, 2019

No description provided.

lilgreenbird and others added 30 commits September 4, 2019 16:20
@lilgreenbird
add enclaveAttestationUrl property
55d0840
@rene-ye
Merge pull request microsoft#1140 from lilgreenbird/aev2
6f543bf 
add enclaveAttestationUrl property
@lilgreenbird
enclaveType
bd214ad
@lilgreenbird
enclaveType (microsoft#1141)
0557d1a
@lilgreenbird
added some junit tests and attestationProtocol property
5b0fee0
@lilgreenbird
resovled conflicts
22fa9bb
@rene-ye
Add | Enclave STuff
6cb3994
@lilgreenbird
Merge branch 'aev2' of https://github.com/rene-ye/mssql-jdbc into aev2
ae19d23
@rene-ye
asdf
4bc018f
@lilgreenbird
Merge branch 'aev2' of https://github.com/rene-ye/mssql-jdbc into aev2
7aceb50
@lilgreenbird
merged with Rene
0898459
@rene-ye
asd
ca3b4ed
@lilgreenbird
Merge branch 'aev2' of https://github.com/rene-ye/mssql-jdbc into aev2
793eb38
@rene-ye
asdf
72e4daa
@lilgreenbird
merged
7a81056
@rene-ye
fix server stuff
bd5ddca
@lilgreenbird
save work
0816100
@rene-ye
parse json
256aae7
@rene-ye
Fix ECDH Key
d619849
@lilgreenbird
fixed akv verify
6333f79
@lilgreenbird
merged with rene
b78470f
@rene-ye
Add | generate session key
aa11348
@lilgreenbird
merged with Rene
f37606f
@lilgreenbird
Merge remote-tracking branch 'upstream/dev' into dev
e2869d5
Merge branch 'aev2' of https://github.com/lilgreenbird/mssql-jdbc int…
4d9b2eb 
…o dev
@lilgreenbird
merged dev
c203a2f
@lilgreenbird
merged
af25a94
@lilgreenbird
Merge remote-tracking branch 'upstream/dev' into dev
1a70872
@lilgreenbird
merged
b86eef3
@lilgreenbird
updated to use reqExternalSetup tag
c4acfb8
@lilgreenbird lilgreenbird changed the title more AE tests and updated AE properties not not read from env variable more AE tests and updated AE properties to not read from env variable Nov 19, 2019
@codecov-io
Copy link
Copy Markdown

codecov-io commented Nov 19, 2019 •
edited
Loading

Codecov Report

Merging #1186 into dev will increase coverage by 0.73%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #1186      +/-   ##
============================================
+ Coverage     55.85%   56.59%   +0.73%     
- Complexity     3550     3643      +93     
============================================
  Files           130      130              
  Lines         29332    29332              
  Branches       4855     4855              
============================================
+ Hits          16383    16599     +216     
+ Misses        10626    10417     -209     
+ Partials       2323     2316       -7
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 47.3% <0%> (-1.3%) 112% <0%> (-1%)
...m/microsoft/sqlserver/jdbc/SQLServerException.java 75.71% <0%> (-0.72%) 35% <0%> (-1%)
...ft/sqlserver/jdbc/SQLServerVSMEnclaveProvider.java 80.39% <0%> (-0.34%) 27% <0%> (ø)
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 39% <0%> (-0.22%) 43% <0%> (-1%)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 51.62% <0%> (+0.06%) 256% <0%> (+1%) ⬆️
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 62.23% <0%> (+0.09%) 0% <0%> (ø) ⬇️
...crosoft/sqlserver/jdbc/KeyStoreProviderCommon.java 64.38% <0%> (+1.36%) 10% <0%> (+1%) ⬆️
...SQLServerColumnEncryptionJavaKeyStoreProvider.java 78.52% <0%> (+11.65%) 21% <0%> (+5%) ⬆️
...m/microsoft/sqlserver/jdbc/KeyVaultCredential.java 84.37% <0%> (+15.62%) 4% <0%> (+2%) ⬆️
...QLServerColumnEncryptionAzureKeyVaultProvider.java 73.02% <0%> (+21.39%) 27% <0%> (+13%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3eb3f12...625fb70. Read the comment docs.

@ulvii ulvii added this to the 8.1.1 milestone Nov 20, 2019
peterbae
peterbae previously approved these changes Nov 21, 2019
View reviewed changes
rene-ye
rene-ye previously approved these changes Nov 22, 2019
View reviewed changes
ulvii
ulvii reviewed Nov 27, 2019
View reviewed changes
Comment thread src/test/java/com/microsoft/sqlserver/jdbc/AlwaysEncrypted/AESetup.java Outdated
ulvii
ulvii reviewed Nov 27, 2019
View reviewed changes
Comment thread src/test/java/com/microsoft/sqlserver/jdbc/AlwaysEncrypted/AESetup.java Outdated
ulvii
ulvii reviewed Nov 27, 2019
View reviewed changes
Comment thread src/test/java/com/microsoft/sqlserver/jdbc/AlwaysEncrypted/JDBCEncryptionDecryptionTest.java Outdated
ulvii
ulvii reviewed Nov 27, 2019
View reviewed changes
Comment thread src/test/java/com/microsoft/sqlserver/jdbc/AlwaysEncrypted/JDBCEncryptionDecryptionTest.java Outdated
ulvii
ulvii reviewed Nov 27, 2019
View reviewed changes
Comment thread src/test/java/com/microsoft/sqlserver/jdbc/AlwaysEncrypted/JDBCEncryptionDecryptionTest.java Outdated
ulvii
ulvii reviewed Nov 27, 2019
View reviewed changes
Comment thread src/test/java/com/microsoft/sqlserver/jdbc/EnclavePackageTest.java
@lilgreenbird lilgreenbird merged commit ca395b0 into microsoft:dev Nov 29, 2019
ulvii pushed a commit that referenced this pull request Mar 3, 2020
@lilgreenbird
more AE tests, config.properties, and updated AE properties to not re…
3ef8357 
…ad from env variable (#1186)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@rene-ye rene-ye rene-ye approved these changes

@ulvii ulvii ulvii approved these changes

@peterbae peterbae peterbae approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

8.1.1

Development

Successfully merging this pull request may close these issues.

5 participants

@lilgreenbird @codecov-io @rene-ye @ulvii @peterbae