Add | Default to null if val is null#1122
Merged
rene-ye merged 1 commit intomicrosoft:devfrom Aug 2, 2019
Merged
Conversation
lilgreenbird
approved these changes
Aug 2, 2019
Contributor
|
I'm not sure this change is necessary. Java specifies that all values in an array of Object are set to null by default. This value couldn't be set to anything else. Because rowValues isn't shared/copied/etc. The value would be null if nothing sets it. |
Member
Author
|
Was kept to keep code aligned. This line was added in a later PR, but was removed after changing the buffer to an arraylist. |
Member
|
This is needed change as there is no "default" value on that index. The change comes from the PR #990 where null value assignment was separated from the original block. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compensating for a change meant to be pushed into a later PR but was reverted with the hotfix.