Release | 7.4.1 Hotfix release#1121
Merged
rene-ye merged 2 commits intomicrosoft:devfrom Aug 2, 2019
Merged
Conversation
lilgreenbird
approved these changes
Aug 2, 2019
rene-ye
approved these changes
Aug 2, 2019
|
|
||
| ## [7.4.1] HotFix & Stable Release | ||
| ### Fixed Issues | ||
| - Reverted [#1025](https://github.com/Microsoft/mssql-jdbc/pull/1025) as it contains breaking changes. This removes `hashCode()` and `equals()` APIs from `SQLServerDataTable` and `SQLServerDataColumn`. |
Member
There was a problem hiding this comment.
Reverted #1025 as it changes API definition for SQLServerDataTable.getIterator() that causes breaking change. This change also removes hashCode() and equals() APIs from SQLServerDataTable and SQLServerDataColumn.
| rowValues.set(key, val); | ||
| rowValues[key] = val; | ||
| break; | ||
|
|
Member
There was a problem hiding this comment.
At Line 301, in the else block before the condition, you need to assign rowValues[key] = null
Contributor
There was a problem hiding this comment.
I'm not sure that needed to happen. rowValues[key] would have already been null since nothing else would have set it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverted #1025 as it contains breaking changes. This removes
hashCode()andequals()APIs fromSQLServerDataTableandSQLServerDataColumn.