Tests | Improve assertions in ComparisonUtil#1100
Merged
ulvii merged 2 commits intomicrosoft:devfrom Aug 21, 2019
Merged
Conversation
Failure message should include the actual/expected values and that is what assertEquals does.
Contributor
|
Hi @harawata, Thanks for the contribution, the team will review the PR. |
Scale difference should be ignored.
Member
|
The comparison isn't intentional, we will address this in a later PR. |
rene-ye
approved these changes
Aug 21, 2019
lilgreenbird
approved these changes
Aug 21, 2019
ulvii
approved these changes
Aug 21, 2019
ulvii
added a commit
that referenced
this pull request
Oct 16, 2019
* Release | Update SNAPSHOT for 7.5.0-preview release (#1129) * Release | Update driver version * Release| Add pom and gradle files * Fix | Remove extra spaces in SQLServerDatabaseMetaData.getNumericFunctions()/SQLServerDatabaseMetaData.getStringFunctions() return values (#1117) * Tests | Improve assertions in ComparisonUtil (#1100) * ComparisonUtil : replace assertTrue with assertEquals Failure message should include the actual/expected values and that is what assertEquals does. * Corrected BigDecimal comparison Scale difference should be ignored. * Fix | Add list of trusted endpoints for AKV (#1130) * added list of trusted endpoints * rename * Update issue templates (#1148) * Fix getImportedKeys() returning duplicate rows if multiple FKs have the same name (#1092) * fixed for github #1091 dup rows * Fix STAsBinary returning null for a single point (#1074) * populate wkb for point * fix stasbinary issue * change variable name * apply same variable name change * Performance | Improved performance of column name string lookups (#1066) * Fix | Made column name lookup more performant * Fix | Spacing * Fix | Changed arraylist to maps * Fix | Add newline * Add | Caching for previously retrieved columns * Fix | Formatting * Fix | Variable issue * Fix | null order * Fix | part 2 * Revert | Integer changes * Fix | Trim retrieved column name * Fix | Clear column names whenever ResultSet cursor is moved * Revert "Fix | Clear column names whenever ResultSet cursor is moved" This reverts commit db42d44. * Add | Implement hashCode() and equals() APIs for SQLServerDataTable and SQLServerDataColumn (#1146) * Add | Add hashCode()/equals() methods to SQLServerDataColumn and SQLServerDataTable * Fix issue with truststore password being removed too early for XA transaction (#1133) Fix | Fix issue with truststore password being removed too early for XA transaction * Fix | SQLServerDatabaseMetada.getColumns not escaping wildcard (#1138) * Feature | Introduce JAVA 13 Support (#1151) * JDK 13 | Remove jre12 from pom file * JDK 13 | Update Gradle build file * JDK 13 | Update Azure-pipelines * Test | Updated SQL Server from 2008R2 to 2012 in CI (#1153) * Performance | Disabled pattern matching when using CallableStatements and SQLServerParameterMetaData (#1149) * Fix | Added ISQLServerBulkData to remove implementation details from ISQLServerBulkRecord (#1099) * Feature | Added support for Always Encrypted with Secure Enclaves (#1155) * Release | 8.1.0-preview release changes (#1158)
ulvii
pushed a commit
that referenced
this pull request
Mar 3, 2020
* ComparisonUtil : replace assertTrue with assertEquals Failure message should include the actual/expected values and that is what assertEquals does. * Corrected BigDecimal comparison Scale difference should be ignored.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failure message should always include the expected/actual values.
Currently, they are added manually in some cases, but it seems to make more sense to use
assertEquals.BTW, I noticed that the assertion comparing
java.sql.Dates only comparesDAY_OF_MONTH.Is it intentional?
It was committed in 1153362#diff-d4cfc7fdd584aa2ec6cec3e2fcaef964R146 .