Skip to content

Test | Close leaking callablestatement#1080

Merged
ulvii merged 2 commits intomicrosoft:devfrom
rene-ye:testFix
Jun 22, 2019
Merged

Test | Close leaking callablestatement#1080
ulvii merged 2 commits intomicrosoft:devfrom
rene-ye:testFix

Conversation

@rene-ye
Copy link
Copy Markdown
Member

@rene-ye rene-ye commented Jun 10, 2019 •
edited
Loading

Fixes thread ID issue in CI's.

@rene-ye rene-ye changed the title Fix | Close leaking callablestatement Test | Close leaking callablestatement Jun 10, 2019
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jun 10, 2019 •
edited
Loading

Codecov Report

Merging #1080 into dev will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #1080      +/-   ##
============================================
- Coverage     54.14%   54.11%   -0.03%     
  Complexity     3272     3272              
============================================
  Files           121      121              
  Lines         28535    28535              
  Branches       4735     4735              
============================================
- Hits          15449    15443       -6     
- Misses        10805    10809       +4     
- Partials       2281     2283       +2
Impacted Files Coverage Δ Complexity Δ
...soft/sqlserver/jdbc/SQLServerDatabaseMetaData.java 39.8% <0%> (ø) 76 <0> (ø) ⬇️
...ooglecode/concurrentlinkedhashmap/LinkedDeque.java 26.15% <0%> (-2.31%) 18% <0%> (-2%)
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 59.69% <0%> (-0.44%) 90% <0%> (-1%)
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 47.3% <0%> (-0.22%) 112% <0%> (+1%)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 61% <0%> (-0.14%) 0% <0%> (ø)
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 39.65% <0%> (+0.86%) 45% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ff36a5...f98c6ab. Read the comment docs.

@ulvii ulvii added this to the 7.4.0 milestone Jun 20, 2019
@ulvii ulvii merged commit 7f67d20 into microsoft:dev Jun 22, 2019
@rene-ye rene-ye deleted the testFix branch October 10, 2019 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cheenamalhotra cheenamalhotra Awaiting requested review from cheenamalhotra

@peterbae peterbae Awaiting requested review from peterbae

2 more reviewers

@lilgreenbird lilgreenbird lilgreenbird approved these changes

@ulvii ulvii ulvii approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

7.4.0

Development

Successfully merging this pull request may close these issues.

4 participants

@rene-ye @codecov-io @lilgreenbird @ulvii