Skip to content

Config | Add Checkstyle configuration file#1067

Merged
cheenamalhotra merged 2 commits intomicrosoft:devfrom
cheenamalhotra:checkstyle
May 30, 2019
Merged

Config | Add Checkstyle configuration file#1067
cheenamalhotra merged 2 commits intomicrosoft:devfrom
cheenamalhotra:checkstyle

Conversation

@cheenamalhotra
Copy link
Copy Markdown
Member

@cheenamalhotra cheenamalhotra commented May 23, 2019

Adding checkstyle XML to project, to be used in IDE for development/reviews of new changes.

peterbae
peterbae previously approved these changes May 23, 2019
View reviewed changes
rene-ye
rene-ye previously approved these changes May 23, 2019
View reviewed changes
@codecov-io
Copy link
Copy Markdown

codecov-io commented May 24, 2019 •
edited
Loading

Codecov Report

Merging #1067 into dev will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #1067      +/-   ##
============================================
- Coverage     53.06%   52.99%   -0.08%     
+ Complexity     3165     3161       -4     
============================================
  Files           119      119              
  Lines         28023    28023              
  Branches       4680     4680              
============================================
- Hits          14871    14851      -20     
- Misses        10928    10951      +23     
+ Partials       2224     2221       -3
Impacted Files Coverage Δ Complexity Δ
...m/microsoft/sqlserver/jdbc/SQLServerException.java 71.42% <0%> (-3.58%) 31% <0%> (-3%)
...om/microsoft/sqlserver/jdbc/SimpleInputStream.java 55.97% <0%> (-1.5%) 15% <0%> (-1%)
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 38.36% <0%> (-0.87%) 42% <0%> (-2%)
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 46.22% <0%> (-0.65%) 110% <0%> (-1%)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 60.83% <0%> (-0.27%) 0% <0%> (ø)
...n/java/com/microsoft/sqlserver/jdbc/Parameter.java 67.41% <0%> (-0.21%) 64% <0%> (ø)
...oft/sqlserver/jdbc/SQLServerPreparedStatement.java 53.31% <0%> (-0.13%) 216% <0%> (-1%)
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 68.54% <0%> (-0.12%) 0% <0%> (ø)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 44.37% <0%> (+0.19%) 330% <0%> (+3%) ⬆️
...a/com/microsoft/sqlserver/jdbc/PLPInputStream.java 60.94% <0%> (+1.18%) 35% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56268e4...5533821. Read the comment docs.

@cheenamalhotra cheenamalhotra dismissed stale reviews from rene-ye and peterbae via 5533821 May 24, 2019 16:19
@cheenamalhotra cheenamalhotra added this to the 7.3.1 milestone May 27, 2019
@cheenamalhotra cheenamalhotra requested a review from ulvii May 27, 2019 21:16
@cheenamalhotra cheenamalhotra merged commit b2ecbdc into microsoft:dev May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@rene-ye rene-ye rene-ye approved these changes

@ulvii ulvii ulvii approved these changes

@peterbae peterbae peterbae approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

7.3.1

Development

Successfully merging this pull request may close these issues.

5 participants

@cheenamalhotra @codecov-io @rene-ye @ulvii @peterbae