Maven | Add Shade plugin configuration to package the driver in an uber-jar#1043
Merged
cheenamalhotra merged 11 commits intomicrosoft:devfrom May 29, 2019
Merged
Maven | Add Shade plugin configuration to package the driver in an uber-jar#1043cheenamalhotra merged 11 commits intomicrosoft:devfrom
cheenamalhotra merged 11 commits intomicrosoft:devfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1043 +/- ##
============================================
- Coverage 53.14% 52.91% -0.24%
+ Complexity 3172 3142 -30
============================================
Files 119 119
Lines 28036 27986 -50
Branches 4680 4676 -4
============================================
- Hits 14899 14808 -91
- Misses 10921 10951 +30
- Partials 2216 2227 +11
Continue to review full report at Codecov.
|
cheenamalhotra
requested review from
cheenamalhotra,
lilgreenbird,
peterbae and
ulvii
lilgreenbird
previously approved these changes
Apr 24, 2019
cheenamalhotra
previously approved these changes
Apr 25, 2019
peterbae
previously approved these changes
Apr 26, 2019
Contributor
|
PR needs to be updated to reflect JRE12 changes. |
rene-ye
dismissed stale reviews from peterbae, cheenamalhotra, and lilgreenbird
via
58d19da
Reduce Shaded JAR size and exclude unwanted artifacts (if included by deps)
cheenamalhotra
approved these changes
May 15, 2019
peterbae
approved these changes
May 16, 2019
cheenamalhotra
changed the title
ulvii
approved these changes
May 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packages all the dependencies used by the driver.