Fix | Mark spatial datatypes as valid#1035
Merged
peterbae merged 3 commits intomicrosoft:devfrom May 13, 2019
Merged
Conversation
Contributor
Author
|
mssql-jdbc-7.3.1-SNAPSHOT-preview-PR1035.zip Attaching the driver from this PR for testing. |
Codecov Report
@@ Coverage Diff @@
## dev #1035 +/- ##
============================================
+ Coverage 50.83% 50.85% +0.02%
- Complexity 2964 2967 +3
============================================
Files 120 120
Lines 28001 28011 +10
Branches 4686 4686
============================================
+ Hits 14233 14245 +12
+ Misses 11616 11613 -3
- Partials 2152 2153 +1
Continue to review full report at Codecov.
|
rene-ye
approved these changes
Apr 25, 2019
cheenamalhotra
changed the title
cheenamalhotra
approved these changes
May 1, 2019
lilgreenbird
approved these changes
May 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issue #1031 and #1038.
For #1031, I changed the isValid bit to be set to
trueby default, as it is stated in the CLR specs. Leaving this isValid bit to false makes some of the Spatial Datatype operations on the server's end fail.For #1038, I've declared the default constructors as protected, to allow extension of Geometry and Geography classes.
I've also noticed that setObject() using Geography/Geometry weren't working as intended, so I'm fixing that as well.