Skip to content

Add | Implement hashCode() and equals() APIs for SQLServerDataTable and SQLServerDataColumn#1025

Merged
cheenamalhotra merged 8 commits intomicrosoft:devfrom
cheenamalhotra:feature1023
May 17, 2019
Merged

Add | Implement hashCode() and equals() APIs for SQLServerDataTable and SQLServerDataColumn#1025
cheenamalhotra merged 8 commits intomicrosoft:devfrom
cheenamalhotra:feature1023

Conversation

@cheenamalhotra
Copy link
Copy Markdown
Member

@cheenamalhotra cheenamalhotra commented Apr 8, 2019

Resolves #1023

Merged PR #1024 to move Test class to tvp package.

This was referenced Apr 8, 2019
Closed
Closed
@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 8, 2019

Codecov Report

Merging #1025 into dev will increase coverage by 0.07%.
The diff coverage is 77.77%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #1025      +/-   ##
============================================
+ Coverage     50.09%   50.17%   +0.07%     
- Complexity     2878     2890      +12     
============================================
  Files           120      120              
  Lines         27989    28016      +27     
  Branches       4677     4685       +8     
============================================
+ Hits          14022    14057      +35     
+ Misses        11713    11697      -16     
- Partials       2254     2262       +8
Flag Coverage Δ Complexity Δ
#JDBC42 49.77% <77.77%> (+0.11%) 2851 <8> (+14) ⬆️
#JDBC43 50.04% <77.77%> (+0.03%) 2882 <8> (+5) ⬆️
Impacted Files Coverage Δ Complexity Δ
...m/microsoft/sqlserver/jdbc/SQLServerDataTable.java 68.57% <71.42%> (+2.69%) 34 <4> (+5) ⬆️
.../microsoft/sqlserver/jdbc/SQLServerDataColumn.java 81.81% <84.61%> (+4.04%) 5 <4> (+4) ⬆️
...om/microsoft/sqlserver/jdbc/SimpleInputStream.java 52.23% <0%> (-1.5%) 11% <0%> (-1%)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 50.39% <0%> (-0.13%) 245% <0%> (-1%)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 55.55% <0%> (+0.06%) 0% <0%> (ø) ⬇️
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 68.41% <0%> (+0.17%) 0% <0%> (ø) ⬇️
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 38.57% <0%> (+0.21%) 43% <0%> (+1%) ⬆️
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 62.93% <0%> (+0.43%) 92% <0%> (+1%) ⬆️
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 47.3% <0%> (+1.07%) 112% <0%> (+2%) ⬆️
...m/microsoft/sqlserver/jdbc/SQLServerException.java 78.1% <0%> (+1.45%) 33% <0%> (+1%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1a004e...86de7c9. Read the comment docs.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 8, 2019 •
edited
Loading

Codecov Report

Merging #1025 into dev will increase coverage by 2.03%.
The diff coverage is 67.21%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #1025      +/-   ##
============================================
+ Coverage     50.92%   52.96%   +2.03%     
- Complexity     2958     3153     +195     
============================================
  Files           120      119       -1     
  Lines         28001    28022      +21     
  Branches       4686     4688       +2     
============================================
+ Hits          14259    14841     +582     
+ Misses        11595    10940     -655     
- Partials       2147     2241      +94
Flag Coverage Δ Complexity Δ
#JDBC42 ? ?
#JDBC43 ? ?
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/com/microsoft/sqlserver/jdbc/TVP.java 43.72% <100%> (ø) 26 <0> (ø) ⬇️
...m/microsoft/sqlserver/jdbc/SQLServerDataTable.java 70.74% <57.89%> (+4.87%) 36 <5> (+7) ⬆️
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 60.93% <66.66%> (+2.94%) 0 <0> (ø) ⬇️
.../microsoft/sqlserver/jdbc/SQLServerDataColumn.java 79.16% <80%> (+1.38%) 7 <6> (+6) ⬆️
...m/microsoft/sqlserver/jdbc/ActivityCorrelator.java 78.37% <0%> (-13.52%) 9% <0%> (ø)
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 59.69% <0%> (-3.67%) 90% <0%> (-5%)
...icrosoft/sqlserver/jdbc/SQLServerXAConnection.java 63.63% <0%> (-3.04%) 2% <0%> (ø)
...m/microsoft/sqlserver/jdbc/SQLServerException.java 72.85% <0%> (-2.15%) 32% <0%> (ø)
...ooglecode/concurrentlinkedhashmap/LinkedDeque.java 26.15% <0%> (-1.54%) 17% <0%> (-2%)
.../microsoft/sqlserver/jdbc/SQLServerDataSource.java 46.39% <0%> (-0.93%) 71% <0%> (ø)
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3242324...71a2111. Read the comment docs.

peterbae
peterbae reviewed Apr 8, 2019
View reviewed changes
Comment thread src/main/java/com/microsoft/sqlserver/jdbc/SQLServerDataColumn.java Outdated
peterbae
peterbae reviewed Apr 12, 2019
View reviewed changes
Comment thread src/main/java/com/microsoft/sqlserver/jdbc/SQLServerDataColumn.java
@cheenamalhotra cheenamalhotra added this to the 7.3.1 milestone Apr 16, 2019
lilgreenbird
lilgreenbird previously approved these changes Apr 17, 2019
View reviewed changes
peterbae
peterbae previously approved these changes May 10, 2019
View reviewed changes
rene-ye
rene-ye previously approved these changes May 10, 2019
View reviewed changes
@cheenamalhotra cheenamalhotra dismissed stale reviews from rene-ye, peterbae, and lilgreenbird via 8a300d9 May 15, 2019 22:01
@cheenamalhotra cheenamalhotra merged commit b91c7ea into microsoft:dev May 17, 2019
@cheenamalhotra cheenamalhotra added the Public API Changes in Public API label May 19, 2019
@ulvii ulvii mentioned this pull request Aug 2, 2019
Merged
@ulvii ulvii mentioned this pull request Sep 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers

@rene-ye rene-ye rene-ye approved these changes

@ulvii ulvii ulvii approved these changes

@peterbae peterbae peterbae approved these changes

@lilgreenbird lilgreenbird lilgreenbird left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Public API Changes in Public API

Projects

None yet

Milestone

7.3.1

Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] SQLServerDataTable and SQLServerDataColumn implementing equals

6 participants

@cheenamalhotra @codecov-io @rene-ye @lilgreenbird @ulvii @peterbae