Skip to content

SQLServerDataTable.clear() now reset columnNames as well#1024

Closed
jorge-lavin wants to merge 1 commit intomicrosoft:devfrom
jorge-lavin:dev
Closed

SQLServerDataTable.clear() now reset columnNames as well#1024
jorge-lavin wants to merge 1 commit intomicrosoft:devfrom
jorge-lavin:dev

Conversation

@jorge-lavin
Copy link
Copy Markdown

@jorge-lavin jorge-lavin commented Apr 8, 2019

No description provided.

@msftclas
Copy link
Copy Markdown

msftclas commented Apr 8, 2019 •
edited
Loading

CLA assistant check
All CLA requirements met.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 8, 2019 •
edited
Loading

Codecov Report

Merging #1024 into dev will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #1024      +/-   ##
============================================
+ Coverage     50.09%   50.11%   +0.01%     
  Complexity     2878     2878              
============================================
  Files           120      120              
  Lines         27989    27990       +1     
  Branches       4677     4677              
============================================
+ Hits          14022    14027       +5     
+ Misses        11713    11703      -10     
- Partials       2254     2260       +6
Flag Coverage Δ Complexity Δ
#JDBC42 49.68% <100%> (+0.03%) 2839 <0> (+2) ⬆️
#JDBC43 50.03% <100%> (+0.01%) 2874 <0> (-3) ⬇️
Impacted Files Coverage Δ Complexity Δ
...m/microsoft/sqlserver/jdbc/SQLServerDataTable.java 68.5% <100%> (+2.63%) 30 <0> (+1) ⬆️
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 40.65% <0%> (-4.4%) 13% <0%> (-2%)
...om/microsoft/sqlserver/jdbc/SimpleInputStream.java 52.23% <0%> (-1.5%) 11% <0%> (-1%)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 50.39% <0%> (-0.13%) 245% <0%> (-1%)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 55.38% <0%> (-0.1%) 0% <0%> (ø)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 43.79% <0%> (-0.08%) 317% <0%> (-1%)
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 68.47% <0%> (+0.23%) 0% <0%> (ø) ⬇️
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 39% <0%> (+0.64%) 43% <0%> (+1%) ⬆️
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 47.3% <0%> (+1.07%) 112% <0%> (+2%) ⬆️
...m/microsoft/sqlserver/jdbc/SQLServerException.java 78.1% <0%> (+1.45%) 33% <0%> (+1%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1a004e...7074f52. Read the comment docs.

This was referenced Apr 8, 2019
Merged
Closed
@cheenamalhotra
Copy link
Copy Markdown
Member

cheenamalhotra commented Apr 8, 2019

PR changes pulled in #1025.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jorge-lavin @msftclas @codecov-io @cheenamalhotra @lilgreenbird