Skip to content

Test | Fix hardcoded Trigger Name causing failures in concurrent builds#1004

Merged
cheenamalhotra merged 1 commit intomicrosoft:devfrom
cheenamalhotra:fixHardcodedName
Mar 29, 2019
Merged

Test | Fix hardcoded Trigger Name causing failures in concurrent builds#1004
cheenamalhotra merged 1 commit intomicrosoft:devfrom
cheenamalhotra:fixHardcodedName

Conversation

@cheenamalhotra
Copy link
Copy Markdown
Member

@cheenamalhotra cheenamalhotra commented Mar 22, 2019

No description provided.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 22, 2019

Codecov Report

Merging #1004 into dev will increase coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##                dev    #1004     +/-   ##
===========================================
+ Coverage     50.09%   50.19%   +0.1%     
- Complexity     2879     2884      +5     
===========================================
  Files           120      120             
  Lines         27989    27989             
  Branches       4677     4677             
===========================================
+ Hits          14020    14048     +28     
+ Misses        11709    11689     -20     
+ Partials       2260     2252      -8
Flag Coverage Δ Complexity Δ
#JDBC42 49.69% <ø> (+0.02%) 2839 <ø> (-2) ⬇️
#JDBC43 50.1% <ø> (+0.12%) 2881 <ø> (+11) ⬆️
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 68.47% <0%> (+0.11%) 0% <0%> (ø) ⬇️
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 47.51% <0%> (+0.21%) 111% <0%> (-1%) ⬇️
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 44.05% <0%> (+0.38%) 321% <0%> (+4%) ⬆️
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 55.75% <0%> (+0.39%) 0% <0%> (ø) ⬇️
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 39% <0%> (+0.64%) 44% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84484ed...530a282. Read the comment docs.

1 similar comment
@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 22, 2019 •
edited
Loading

Codecov Report

Merging #1004 into dev will increase coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##                dev    #1004     +/-   ##
===========================================
+ Coverage     50.09%   50.19%   +0.1%     
- Complexity     2879     2884      +5     
===========================================
  Files           120      120             
  Lines         27989    27989             
  Branches       4677     4677             
===========================================
+ Hits          14020    14048     +28     
+ Misses        11709    11689     -20     
+ Partials       2260     2252      -8
Flag Coverage Δ Complexity Δ
#JDBC42 49.69% <ø> (+0.02%) 2839 <ø> (-2) ⬇️
#JDBC43 50.1% <ø> (+0.12%) 2881 <ø> (+11) ⬆️
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 68.47% <0%> (+0.11%) 0% <0%> (ø) ⬇️
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 47.51% <0%> (+0.21%) 111% <0%> (-1%) ⬇️
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 44.05% <0%> (+0.38%) 321% <0%> (+4%) ⬆️
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 55.75% <0%> (+0.39%) 0% <0%> (ø) ⬇️
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 39% <0%> (+0.64%) 44% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84484ed...530a282. Read the comment docs.

@cheenamalhotra cheenamalhotra changed the title Fix | Fix hardcoded Trigger Name causing failures in concurrent builds Test | Fix hardcoded Trigger Name causing failures in concurrent builds Mar 28, 2019
@cheenamalhotra cheenamalhotra added this to the 7.3.1 milestone Mar 28, 2019
@cheenamalhotra cheenamalhotra merged commit 5b02953 into microsoft:dev Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lilgreenbird lilgreenbird Awaiting requested review from lilgreenbird

@ulvii ulvii Awaiting requested review from ulvii

2 more reviewers

@rene-ye rene-ye rene-ye approved these changes

@peterbae peterbae peterbae approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

7.3.1

Development

Successfully merging this pull request may close these issues.

5 participants

@cheenamalhotra @codecov-io @rene-ye @peterbae @lilgreenbird