Skip to content

SQLServerDataTable should not call toString on all objects #531

@cogman

Description

@cogman

Problem description

Right now, SqlServerDataTable will take in a type, if that type is numeric, it will call toString on that type and then it will use whatever numeric type it is turning it into to parse the output string.

String/numeric parsing in java is horribly slow and uses quite a bit of memory. Instead of doing that, DataTable should check "Is this an instance of Number" (which often, it will be), and then should use the various "xValue" methods off of number to turn it into the desired type. toString and parsing should only be called if this method fails.

Metadata

Metadata

Labels

EnhancementAn enhancement to the driver. Lower priority than bugs.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions