Fix for a deadlock discovered in 4169#4245
Merged
nibanks merged 1 commit intomicrosoft:mainfrom Apr 16, 2024
Merged
Conversation
nibanks
approved these changes
Apr 16, 2024
Collaborator
nibanks
left a comment
nibanks
left a comment
There was a problem hiding this comment.
LGTM. If the tests pass, let's ship it!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4245 +/- ##
==========================================
- Coverage 85.44% 85.25% -0.19%
==========================================
Files 56 56
Lines 15380 15382 +2
==========================================
- Hits 13141 13114 -27
- Misses 2239 2268 +29 ☔ View full report in Codecov by Sentry. |
rzikm
changed the title
Member
Author
|
The Stress failures seem to be from inability to even start the stress run, so I guess we are good to go? |
This was referenced Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4242.
Testing
Stress test in CI.
Documentation
N/A