Fix transport error code for new alpn negotiation#3647
Merged
nibanks merged 2 commits intomicrosoft:mainfrom May 24, 2023
Merged
Conversation
Member
|
This should get into whatever msquic version that will be actual when .NET 8 ships. I.e.: backport to 2.2 unless another release from main will be made. |
nibanks
approved these changes
May 24, 2023
Collaborator
Yes, this must also be backported because this breaks 2.2 down level tests, because of the test code change. Would you mind creating the PR to cherry pick this to release/2.2 branch? |
This was referenced May 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, while we're narrowing down the ALPN list with ReNegotiation, if we can't negotiate with client on ALPN, we're closing the connection with
QUIC_ERROR_INTERNAL_ERROR, but looks like it should beQUIC_ERROR_CRYPTO_NO_APPLICATION_PROTOCOL.Testing
I've updated the necessary unit test, but this is a breaking change since we're changing close status behavior.
Documentation
No