[release/2.1] make chacha optional on Linux #3492
Merged
nibanks merged 6 commits intomicrosoft:release/2.1from Mar 16, 2023
Merged
[release/2.1] make chacha optional on Linux #3492nibanks merged 6 commits intomicrosoft:release/2.1from
nibanks merged 6 commits intomicrosoft:release/2.1from
Conversation
nibanks
previously approved these changes
Mar 11, 2023
Collaborator
|
Cargo build is failing for some reason? |
nibanks
reviewed
Mar 11, 2023
Collaborator
|
Member
Author
|
I'll take a look. |
Member
Author
|
It seems like 2.1 did not call |
Collaborator
I agree XDP is unrelated, and not very reliable on 2.1 builds (but is preview anyways). I was looking at the code and noticed a call to unitialized was not added, and then saw that uninitialize doesn't do anything. Shouldn't it be cleaning up stuff? |
nibanks
reviewed
Mar 15, 2023
nibanks
approved these changes
Mar 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of two changes to load msquic on Centos 7 and Mariner Linux 2.0
fixes #3422