Skip to content

build libssl with no-seed#3394

Merged
nibanks merged 1 commit intomicrosoft:mainfrom
wfurt:seed
Feb 4, 2023
Merged

build libssl with no-seed#3394
nibanks merged 1 commit intomicrosoft:mainfrom
wfurt:seed

Conversation

@wfurt
Copy link
Member

@wfurt wfurt commented Feb 3, 2023

follow-up on dotnet/runtime#81481 (comment)
attempt to use system crypto fails on Alpine Linux

ldd /usr/lib/libmsquic.so.2
        /lib/ld-musl-x86_64.so.1 (0x7fbc0efdf000)
        libcrypto.so.1.1 => /lib/libcrypto.so.1.1 (0x7fbc0ec00000)
        libc.musl-x86_64.so.1 => /lib/ld-musl-x86_64.so.1 (0x7fbc0efdf000)
Error relocating /usr/lib/libmsquic.so.2: EVP_seed_cbc: symbol not found

It is because it is build with no-seed
https://git.alpinelinux.org/aports/tree/main/openssl/APKBUILD?h=3.15-stable#n110

I could make this Alpine specific but I feel like we should not pull in parts that we don't need.
So I left it as general change to decrease expectation from OS.

@wfurt wfurt requested a review from a team as a code owner February 3, 2023 21:30
@wfurt
Copy link
Member Author

wfurt commented Feb 3, 2023

cc: @ManickaP

@nibanks nibanks merged commit 662ef33 into microsoft:main Feb 4, 2023
@wfurt wfurt deleted the seed branch February 4, 2023 05:05
@wfurt wfurt mentioned this pull request Feb 6, 2023
Merged
This was referenced Feb 8, 2023
Merged
Closed
nibanks pushed a commit that referenced this pull request Feb 11, 2023
@wfurt
build libssl with no-seed (#3394) (#3417)
4cb3878
@wfurt wfurt mentioned this pull request Feb 17, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nibanks nibanks nibanks approved these changes

Assignees

No one assigned

Labels

TLS: quicTLS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wfurt @nibanks