Skip to content

fix build on Ubuntu 18#3379

Merged
nibanks merged 1 commit intomicrosoft:mainfrom
wfurt:UDP_GRO
Feb 1, 2023
Merged

fix build on Ubuntu 18#3379
nibanks merged 1 commit intomicrosoft:mainfrom
wfurt:UDP_GRO

Conversation

@wfurt
Copy link
Member

@wfurt wfurt commented Jan 27, 2023

it would fail as

[ 86%] Building C object src/platform/CMakeFiles/platform.dir/certificates_posix.c.o
cd /home/furt/github/wfurt-msquic/build/linux/x64_openssl/src/platform && /usr/bin/cc -DCXPLAT_NUMA_AWARE -DCX_PLATFORM_LINUX -DHAS_SENDMMSG -DHAS_SYSCONF -DHAS__SC_PHYS_PAGES -DQUIC_CLOG -DQUIC_ENABLE_CA_CERTIFICATE_FILE_TESTS -DQUIC_SHARED_EPHEMERAL_WORKAROUND -DQUIC_TEST_OPENSSL_FLAGS=1 -DVER_BUILD_ID=0 -DVER_GIT_HASH=216fc71d3ef68c7b63cd5666306aba8bc564e5ef -DVER_SUFFIX=-private -D_GNU_SOURCE -I/home/furt/github/wfurt-msquic/src/inc -I/home/furt/github/wfurt-msquic/src/generated/common -I/home/furt/github/wfurt-msquic/src/generated/linux -I/home/furt/github/wfurt-msquic/build/linux/x64_openssl/_deps/opensslquic-build/openssl/include  -Og -ggdb3   -fms-extensions -fPIC -Werror -Wall -Wextra -Wformat=2 -Wno-type-limits -Wno-unknown-pragmas -Wno-multichar -Wno-missing-field-initializers -o CMakeFiles/platform.dir/certificates_posix.c.o   -c /home/furt/github/wfurt-msquic/src/platform/certificates_posix.c
/home/furt/github/wfurt-msquic/src/platform/datapath_epoll.c: In function ‘CxPlatSocketContextInitialize’:
/home/furt/github/wfurt-msquic/src/platform/datapath_epoll.c:1193:17: error: ‘UDP_GRO’ undeclared (first use in this function); did you mean ‘UDP_CORK’?
                 UDP_GRO,
                 ^~~~~~~
                 UDP_CORK
/home/furt/github/wfurt-msquic/src/platform/datapath_epoll.c:1193:17: note: each undeclared identifier is reported only once for each function it appears in
/home/furt/github/wfurt-msquic/src/platform/datapath_epoll.c: In function ‘CxPlatSocketContextRecvComplete’:
/home/furt/github/wfurt-msquic/src/platform/datapath_epoll.c:1810:40: error: ‘UDP_GRO’ undeclared (first use in this function); did you mean ‘UDP_CORK’?
                 if (CMsg->cmsg_type == UDP_GRO) {
                                        ^~~~~~~
                                        UDP_CORK
/home/furt/github/wfurt-msquic/src/platform/platform_posix.c:40:10: fatal error: numa.h: No such file or directory
 #include <numa.h>

it seems like UDP_GRO is not consistently guarded by #ifdef

The numa failure is fixable by installing libnuma-dev package. It would be nice if the detection works better but the workaround is simple enough.

@wfurt wfurt requested a review from a team as a code owner January 27, 2023 04:02
@nibanks nibanks merged commit b6a46e3 into microsoft:main Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants