Fixed details of stream SHUTDOWN_COMPLETE for ConnectionShutdown#2883
Merged
nibanks merged 2 commits intomicrosoft:mainfrom Jul 15, 2022
Merged
Conversation
nibanks
reviewed
Jul 11, 2022
ManickaP
force-pushed
the
mapichov/fix-stream-shutdown-details
branch
from
b99b158 to
dc26c79
Compare
nibanks
previously approved these changes
Jul 13, 2022
ManickaP
force-pushed
the
mapichov/fix-stream-shutdown-details
branch
from
91a3628 to
8a393d4
Compare
ManickaP
force-pushed
the
mapichov/fix-stream-shutdown-details
branch
from
8a393d4 to
b8c2786
Compare
ManickaP
force-pushed
the
mapichov/fix-stream-shutdown-details
branch
from
b8c2786 to
f02303e
Compare
Member
Author
|
Looks like failing tests are unrelated, but please check after me, I'm not familiar well with your infra. |
nibanks
approved these changes
Jul 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Small follow up on #2872. Renamed "ByPeer" to "ByApp" since it applies to local connection close as well. And included info whether it's local or remote close.
Testing
System.Net.Quic tests.
Documentation
No, docs do not include event details.