Include connection close details in stream's SHUTDOWN_COMPLETE#2872
Merged
nibanks merged 2 commits intomicrosoft:mainfrom Jul 7, 2022
Merged
Include connection close details in stream's SHUTDOWN_COMPLETE#2872nibanks merged 2 commits intomicrosoft:mainfrom
nibanks merged 2 commits intomicrosoft:mainfrom
Conversation
Collaborator
|
I'm fine with this change. |
ManickaP
force-pushed
the
mapichov/stream-shutdown-details
branch
from
c95bd00 to
d2a442d
Compare
ManickaP
force-pushed
the
mapichov/stream-shutdown-details
branch
from
d2a442d to
9d388b1
Compare
nibanks
approved these changes
Jul 7, 2022
Collaborator
Yeah, we still haven't added the stream event documentation. |
This was referenced Jul 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is just a proposal of a change that would eventually help us get rid of an explicit link from stream to connection. We'd like to adopt
SafeHandlereference counting to keep connection alive for all the streams instead of a manual reference counting.The event contains information whether it's happening due to connection closure, but it doesn't contain any details. As a result, the user has to manually keep reference between stream and connection if they want to use those details. This is the last thing that forces us to keep reference from stream to connection.
Testing
Local test with System.Net.Quic and closing the connection via application and via idle timeout while stream is opened.
Documentation
Is there any documentation impact for this change?
Yes. I can fill it in if this proposal gets a green light.