Repository navigation
Conversation
Daan (daanx)
added a commit
that referenced
this pull request
Oct 30, 2026
Collaborator
|
Thanks thexai -- I pushed the smaller fix directly -- hope it works for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up of #1340.
Previously changed to use
LoadPackagedLibraryfor better Xbox compatibility but this is not necessary for system libs (only for app's packaged libs). In fact, it is counterproductive to use it for OS libraries.Since here only is used for kernelbase, ntdll, kernel32, bcrypt and psapi (all system libs) is better remove the use of
LoadPackagedLibrary.Is confirmed is working in Python build for Xbox (Python code includes mimalloc).
This comment #1340 (comment) also supports the same thing.