Skip to content

Make tab corner overlays update colors#5145

Merged
StephenLPeters merged 3 commits intomainfrom
unknown repository
Jul 19, 2021
Merged

Make tab corner overlays update colors#5145
StephenLPeters merged 3 commits intomainfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Jun 4, 2021

Fixes microsoft/terminal#7133

Tab corners only got colored when the tab was created, now they get updated together with the rest of the tab.

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Jun 4, 2021
@karkarl
Copy link
Contributor

karkarl commented Jun 7, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@karkarl
Copy link
Contributor

karkarl commented Jun 8, 2021

There's a pipeline regression, can you pull from main for the workaround?

@ghost
Copy link
Author

ghost commented Jun 8, 2021

I think I did it, does it work now?

@beervoley
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ranjeshj ranjeshj added team-Controls Issue for the Controls team area-TabView and removed needs-triage Issue needs to be triaged by the area owners labels Jun 10, 2021
@ghost
Copy link
Author

ghost commented Jun 22, 2021

@ranjeshj This PR should be ready to merge, but there was a problem with the tests themselves last time. Could you run them again?

@StephenLPeters
Copy link
Contributor

@gabrielconl can you please merge main into your branch to pick up an infrastructure update?

@StephenLPeters
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ghost
Copy link
Author

ghost commented Sep 14, 2021

@StephenLPeters could this be backported to 2.6? Terminal would've liked to have that bug fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-TabView team-Controls Issue for the Controls team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The rounded bottom corner on a tab doesn't get colored by the color picker

4 participants