Skip to content

Innerloop: Add missing TabView API test project#3770

Merged
StephenLPeters merged 5 commits intomicrosoft:masterfrom
Felix-Dev:user/Felix-Dev/innerloop-add-tabview-apitestproject
Feb 26, 2021
Merged

Innerloop: Add missing TabView API test project#3770
StephenLPeters merged 5 commits intomicrosoft:masterfrom
Felix-Dev:user/Felix-Dev/innerloop-add-tabview-apitestproject

Conversation

@Felix-Dev
Copy link
Contributor

Description

This PR adds the existing TabView API test project to the innerloop solution.

How Has This Been Tested?

Verified manually.

Screenshots:

image

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Dec 4, 2020
dev\SplitButton\TestUI\SplitButton_TestUI.projitems*{280c91f4-96b5-4bde-9e02-e573e1def583}*SharedItemsImports = 13
dev\Repeater\TestUI\Repeater_TestUI.projitems*{2ed883f5-20db-4445-8c96-517a21e5e657}*SharedItemsImports = 13
dev\MenuFlyout\TestUI\MenuFlyout_TestUI.projitems*{2ef860e2-8766-41fc-bde2-e6b18bb8c206}*SharedItemsImports = 13
dev\TabView\APITests\TabView_APITests.projitems*{2f4e95e9-f729-481c-b9aa-c9bec91ae395}*SharedItemsImports = 13
Copy link
Contributor Author

@Felix-Dev Felix-Dev Dec 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be a helpful observation to @kmahone or @llongley as part of the discussion about the constant temporary innerloop .sln file changes we have seen over the past months (see this discussion for more context and details): The termporary lines highlighted in that PR use SharedItemsImports = 4 whereas the permanent entry seen above uses SharedItemsImports = 13.

Including the TabView control in the innerloop build process adds the following temporary entries to the innerloop .sln file:

dev\TabView\TabView.vcxitems*{ad0c90b0-4845-4d4b-88f1-86f653f8171b}*SharedItemsImports = 4

dev\TabView\APITests\TabView_APITests.projitems*{dedc1e4f-cfa5-4443-83eb-e79d425df7e7}*SharedItemsImports = 4
dev\TabView\TestUI\TabView_TestUI.projitems*{dedc1e4f-cfa5-4443-83eb-e79d425df7e7}*SharedItemsImports = 4

dev\TabView\APITests\TabView_APITests.projitems*{fbc396f5-26dd-4ca3-981e-c7bc9fea4546}*SharedItemsImports = 4
dev\TabView\TestUI\TabView_TestUI.projitems*{fbc396f5-26dd-4ca3-981e-c7bc9fea4546}*SharedItemsImports = 4

Having this discussion spanning across multiple PRs is also not ideal. We should bundle what we currently know in a separate standalone issue to be used for tracking, additional research and to further think about and discuss possible solutions.

@StephenLPeters
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@StephenLPeters StephenLPeters added area-DevInternal Internal build infrastructure, code cleanup, engineering efficiency area-TabView team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Dec 5, 2020
@StephenLPeters StephenLPeters merged commit 957581f into microsoft:master Feb 26, 2021
@Felix-Dev Felix-Dev deleted the user/Felix-Dev/innerloop-add-tabview-apitestproject branch February 27, 2021 13:49
marcelwgn pushed a commit to marcelwgn/microsoft-ui-xaml that referenced this pull request Mar 5, 2021
* inner loop VS automatic updates

* inner loop VS automatic update

* Add API test project to innerloop solution.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-DevInternal Internal build infrastructure, code cleanup, engineering efficiency area-TabView team-Controls Issue for the Controls team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants