Skip to content

Update visual tree verification infra to get rid of the term "master"#2725

Merged
StephenLPeters merged 5 commits intomicrosoft:masterfrom
marcelwgn:rename-visualtreemaster
Jun 30, 2020
Merged

Update visual tree verification infra to get rid of the term "master"#2725
StephenLPeters merged 5 commits intomicrosoft:masterfrom
marcelwgn:rename-visualtreemaster

Conversation

@marcelwgn
Copy link
Collaborator

@marcelwgn marcelwgn commented Jun 21, 2020

Description

Update documentation, CI scripts and testing code to use new names instead of "master".

Motivation and Context

#2676

How Has This Been Tested?

Ran tests

@msft-github-bot msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label Jun 21, 2020
StephenLPeters
StephenLPeters approved these changes Jun 22, 2020
View reviewed changes
Copy link
Contributor

@StephenLPeters StephenLPeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@StephenLPeters
Copy link
Contributor

StephenLPeters commented Jun 22, 2020

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jun 22, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@StephenLPeters
Copy link
Contributor

StephenLPeters commented Jun 22, 2020

@chingucoding have you tested updating the visual verification reference files after this change?

@marcelwgn
Copy link
Collaborator Author

marcelwgn commented Jun 22, 2020

@chingucoding have you tested updating the visual verification reference files after this change?

I have not tested updating file from the CI. Also we would probably need new screen shots for those since they don't have the new folder name.

@StephenLPeters StephenLPeters mentioned this pull request Jun 22, 2020
Merged
@StephenLPeters StephenLPeters added area-DevInternal Internal build infrastructure, code cleanup, engineering efficiency team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Jun 22, 2020
@marcelwgn
Copy link
Collaborator Author

marcelwgn commented Jun 22, 2020 •
edited
Loading

@StephenLPeters Should I revert my changes to the documentation and let #2660 include those changes to prevent merge conflicts? @Felix-Dev Would you be fine with that?

@Felix-Dev
Copy link
Contributor

Felix-Dev commented Jun 22, 2020 •
edited
Loading

@chingucoding I'm fine with merging your changes into my PR and fixing any occuring merge conflicts in the developer documentation file (and update it accordingly to use the new term where I added new content).

@StephenLPeters
Copy link
Contributor

StephenLPeters commented Jun 25, 2020

@chingucoding have you tested updating the visual verification reference files after this change?

I have not tested updating file from the CI. Also we would probably need new screen shots for those since they don't have the new folder name.

Does this have to be done in a subsequent checkin or can we do it atomically?

@marcelwgn
Copy link
Collaborator Author

marcelwgn commented Jun 25, 2020

I have not tested updating file from the CI. Also we would probably need new screen shots for those since they don't have the new folder name.
Does this have to be done in a subsequent checkin or can we do it atomically?

Since there are no visual tree verification updates, and the only screenshot right now is the azure artifacts view I don't have access too, there is no screenshot I can update here. If someone with access to the azure directory can provide a screenshot for the updated "microsoft employee" view, we can update it with this PR. However currently the "VisualTree" folder is not present in the drop since there were no changes to the visual tree verification files.

@marcelwgn
Copy link
Collaborator Author

marcelwgn commented Jun 25, 2020

However since #2660 also introduces new screenshots that also need to be updated, we could also do it with that PR is @Felix-Dev is fine with that.

@StephenLPeters
Copy link
Contributor

StephenLPeters commented Jun 26, 2020

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jun 26, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@StephenLPeters
Copy link
Contributor

StephenLPeters commented Jun 30, 2020

However since #2660 also introduces new screenshots that also need to be updated, we could also do it with that PR is @Felix-Dev is fine with that.

@chingucoding and @Felix-Dev how should we progress with merging in this and #2660? I think merging this and updating #2660 would make sense?

@Felix-Dev
Copy link
Contributor

Felix-Dev commented Jun 30, 2020

@StephenLPeters Yes, we can merge this into master first and then update #2660 accordingly.

@StephenLPeters StephenLPeters merged commit 3834f4d into microsoft:master Jun 30, 2020
@kmahone kmahone mentioned this pull request Jul 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@StephenLPeters StephenLPeters StephenLPeters approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-DevInternal Internal build infrastructure, code cleanup, engineering efficiency team-Controls Issue for the Controls team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@marcelwgn @StephenLPeters @Felix-Dev @msft-github-bot