Skip to content

Revert change to default AccentForegroundBrush#2420

Merged
ranjeshj merged 2 commits intomicrosoft:masterfrom
marcelwgn:revert-faulty-accentbuttonchanges
May 13, 2020
Merged

Revert change to default AccentForegroundBrush#2420
ranjeshj merged 2 commits intomicrosoft:masterfrom
marcelwgn:revert-faulty-accentbuttonchanges

Conversation

@marcelwgn
Copy link
Collaborator

@marcelwgn marcelwgn commented May 8, 2020

Description

Revert the AccentForeGround resource to a the previous value as the new value was a regression.

Motivation and Context

Fixes regression with Accent buttons

How Has This Been Tested?

Tested manually:
Before:
image

image

After:
image
image

Screenshots (if appropriate):

@msft-github-bot msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label May 8, 2020
@ranjeshj
Copy link
Contributor

ranjeshj commented May 9, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ranjeshj ranjeshj requested review from chigy and jtippet May 9, 2020 04:11
@jtippet
Copy link
Contributor

jtippet commented May 9, 2020

Thanks for fixing this, and sorry about mixing up the colors there.

@ranjeshj
Copy link
Contributor

@chingucoding can you please share the before picture for clarity ?

@ranjeshj ranjeshj added area-UIDesign UI Design, styling team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels May 12, 2020
@marcelwgn
Copy link
Collaborator Author

@chingucoding can you please share the before picture for clarity ?

Sure updated PR description.

@ranjeshj ranjeshj merged commit 4809532 into microsoft:master May 13, 2020
@ranjeshj ranjeshj added the needs-cherrypicktorelease PR tagged for cherry-pick to the current release branch (but not yet picked) label May 13, 2020
@ranjeshj ranjeshj removed the needs-cherrypicktorelease PR tagged for cherry-pick to the current release branch (but not yet picked) label May 13, 2020
@marcelwgn marcelwgn deleted the revert-faulty-accentbuttonchanges branch May 15, 2020 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-UIDesign UI Design, styling team-Controls Issue for the Controls team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants