Update Input Template of RL Policy to Improve Module Flexisiblity#589
Merged
Update Input Template of RL Policy to Improve Module Flexisiblity#589
Conversation
added 7 commits
March 28, 2023 06:00
…_and_agent_state()
…ctor() of current TrainOps; add default False early_stop to update_actor() of current TrainOps
…ent sample() and eval()
added 2 commits
March 28, 2023 08:50
21 tasks
lihuoran
reviewed
Mar 29, 2023
| self, | ||
| states: torch.Tensor, | ||
| actions: torch.Tensor = None, | ||
| **kwargs, |
Contributor
There was a problem hiding this comment.
Is **kwargs used in _shape_check()? Or you just want to keep it for future flexibility?
Contributor
Author
There was a problem hiding this comment.
Not used yet. Only for future flexibility.
lihuoran
approved these changes
Mar 29, 2023
Jinyu-W
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
RL Workflow:
RL Algorithms:
**kwargsto support more problem setting (e.g., Graph based ones)**kwargsto RL models'forwardfuncs and_shape_check()**kwargsto RL policies'get_actionrelated funcs and_post_check()**kwargstochoose_actionsofAbsEnvSampler; remain it None in currentsample()andeval()update_critic()andupdate_actor()of currentTrainOps; add defaultFalseearly_stoptoupdate_actor()of currentTrainOpsLinked issue(s)/Pull request(s)
Type of Change
Related Component
Has Been Tested
Needs Follow Up Actions
Checklist