Skip to content

try fix citi bike hello world dashboard#555

Merged
Jinyu-W merged 2 commits intomicrosoft:masterfrom
zhawan:master
Jul 5, 2022
Merged

try fix citi bike hello world dashboard#555
Jinyu-W merged 2 commits intomicrosoft:masterfrom
zhawan:master

Conversation

@zhawan
Copy link
Copy Markdown
Contributor

@zhawan zhawan commented Jul 4, 2022

Description

try fix citi bike hello world dashboard

Linked issue(s)/Pull request(s)

Type of Change

  • Non-breaking bug fix
  • Breaking bug fix
  • New feature
  • Test
  • Doc update
  • Docker update

Related Component

  • Simulation toolkit
  • RL toolkit
  • Distributed toolkit

Has Been Tested

  • OS:
    • Windows
    • Mac OS
    • Linux
  • Python version:
    • 3.7
    • 3.8
    • 3.9
  • Key information snapshot(s):

Needs Follow Up Actions

  • New release package
  • New docker image

Checklist

  • Add/update the related comments
  • Add/update the related tests
  • Add/update the related documentations
  • Update the dependent downstream modules usage

zhawan added 2 commits July 4, 2022 11:23
remove missed keys in option candidates
use a copy of attribute_option_candidates in functions
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 4, 2022

Codecov Report

Merging #555 (00a745c) into master (f559634) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #555   +/-   ##
=======================================
  Coverage   78.90%   78.90%           
=======================================
  Files          85       85           
  Lines        5455     5455           
=======================================
  Hits         4304     4304           
  Misses       1151     1151           
Flag Coverage Δ
unittests 78.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f559634...00a745c. Read the comment docs.

@zhawan zhawan marked this pull request as ready for review July 4, 2022 03:38
@Jinyu-W Jinyu-W merged commit 67dea17 into microsoft:master Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants