Skip to content

V0.2 rl refinement task queue#406

Merged
buptchan merged 14 commits intov0.2_rl_refinementfrom
v0.2_rl_refinement_taskq
Oct 29, 2021
Merged

V0.2 rl refinement task queue#406
buptchan merged 14 commits intov0.2_rl_refinementfrom
v0.2_rl_refinement_taskq

Conversation

@buptchan
Copy link
Copy Markdown
Contributor

@buptchan buptchan commented Oct 9, 2021

Description

Add task_queue for data parallelism.
Through task queue, policies request gradient workers for each training iteration, instead of a fixed allocation.
WorkerAllocator is removed because it can be replaced by task queue.

Linked issue(s)/Pull request(s)

Type of Change

  • Non-breaking bug fix
  • Breaking bug fix
  • New feature
  • Test
  • Doc update
  • Docker update

Related Component

  • Simulation toolkit
  • RL toolkit
  • Distributed toolkit

Has Been Tested

  • OS:
    • Windows
    • Mac OS
    • Linux
  • Python version:
    • 3.6
    • 3.7
  • Key information snapshot(s):

Needs Follow Up Actions

  • New release package
  • New docker image

Checklist

  • Add/update the related comments
  • Add/update the related tests
  • Add/update the related documentations
  • Update the dependent downstream modules usage

@buptchan buptchan requested review from Jinyu-W and ysqyang October 9, 2021 08:00
ysqyang
ysqyang reviewed Oct 13, 2021
View reviewed changes
ysqyang
ysqyang reviewed Oct 19, 2021
View reviewed changes
ysqyang
ysqyang reviewed Oct 19, 2021
View reviewed changes
ysqyang
ysqyang reviewed Oct 19, 2021
View reviewed changes
ysqyang
ysqyang reviewed Oct 19, 2021
View reviewed changes
ysqyang
ysqyang reviewed Oct 19, 2021
View reviewed changes
ysqyang
ysqyang reviewed Oct 19, 2021
View reviewed changes
ysqyang
ysqyang reviewed Oct 19, 2021
View reviewed changes
ysqyang
ysqyang reviewed Oct 19, 2021
View reviewed changes
ysqyang
ysqyang reviewed Oct 19, 2021
View reviewed changes
ysqyang
ysqyang reviewed Oct 19, 2021
View reviewed changes
ysqyang
ysqyang reviewed Oct 19, 2021
View reviewed changes
ysqyang
ysqyang reviewed Oct 19, 2021
View reviewed changes
ysqyang
ysqyang reviewed Oct 19, 2021
View reviewed changes
ysqyang
ysqyang reviewed Oct 19, 2021
View reviewed changes
ysqyang
ysqyang reviewed Oct 19, 2021
View reviewed changes
ysqyang
ysqyang reviewed Oct 19, 2021
View reviewed changes
ysqyang
ysqyang reviewed Oct 19, 2021
View reviewed changes
ysqyang
ysqyang reviewed Oct 19, 2021
View reviewed changes
ysqyang
ysqyang reviewed Oct 19, 2021
View reviewed changes
ysqyang
ysqyang reviewed Oct 19, 2021
View reviewed changes
ysqyang
ysqyang reviewed Oct 19, 2021
View reviewed changes
ysqyang
ysqyang reviewed Oct 19, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@ysqyang ysqyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More comments

@buptchan
1.Merge data_parallel and num_workers into data_parallelism in config…
6677572 
…; 2.Assign recently used workers as possible in task_queue.
buptchan
buptchan commented Oct 20, 2021
View reviewed changes
Jinyu-W
Jinyu-W reviewed Oct 24, 2021
View reviewed changes
Jinyu-W
Jinyu-W reviewed Oct 25, 2021
View reviewed changes
Jinyu-W
Jinyu-W reviewed Oct 25, 2021
View reviewed changes
Jinyu-W
Jinyu-W reviewed Oct 25, 2021
View reviewed changes
Jinyu-W
Jinyu-W reviewed Oct 25, 2021
View reviewed changes
buptchan
buptchan commented Oct 26, 2021
View reviewed changes
@buptchan buptchan merged commit 1c2d51c into v0.2_rl_refinement Oct 29, 2021
@lihuoran lihuoran mentioned this pull request Oct 29, 2021
Merged
@buptchan buptchan mentioned this pull request Oct 29, 2021
Merged
20 tasks
@lihuoran lihuoran deleted the v0.2_rl_refinement_taskq branch October 29, 2021 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@Jinyu-W Jinyu-W Jinyu-W left review comments

@ysqyang ysqyang ysqyang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@buptchan @ysqyang @Jinyu-W