Skip to content

Cim test coverage#395

Merged
Jinyu-W merged 13 commits intocim_pr_bundlefrom
cim_test_coverage
Sep 17, 2021
Merged

Cim test coverage#395
Jinyu-W merged 13 commits intocim_pr_bundlefrom
cim_test_coverage

Conversation

@lihuoran
Copy link
Copy Markdown
Contributor

@lihuoran lihuoran commented Sep 14, 2021

Description

  • Enrich the test cases of CIM scenario, so that the test coverage could (hopefully) reach 100%.
  • Fix some design drawbacks during the test enrichment.
  • Redesign parsers & data generator: use function to replace class methods.

Linked issue(s)/Pull request(s)

Type of Change

  • Non-breaking bug fix
  • Breaking bug fix
  • New feature
  • Test
  • Doc update
  • Docker update

Related Component

  • Simulation toolkit
  • RL toolkit
  • Distributed toolkit

Has Been Tested

  • OS:
    • Windows
    • Mac OS
    • Linux
  • Python version:
    • 3.6
    • 3.7
  • Key information snapshot(s):

Needs Follow Up Actions

  • New release package
  • New docker image

Checklist

  • Add/update the related comments
  • Add/update the related tests
  • Add/update the related documentations
  • Update the dependent downstream modules usage

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Jinyu-W Jinyu-W Jinyu-W approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lihuoran @Jinyu-W