Skip to content

Fix Geo vis IP address & SQL logic bugs.#383

Merged
lihuoran merged 4 commits intomasterfrom
vis_tool_debug
Aug 2, 2021
Merged

Fix Geo vis IP address & SQL logic bugs.#383
lihuoran merged 4 commits intomasterfrom
vis_tool_debug

Conversation

@lihuoran
Copy link
Copy Markdown
Contributor

@lihuoran lihuoran commented Jul 30, 2021

Description

Fix Geo vis IP address & SQL logic bugs.

As reported in 352, the Geo vis frontend app could not access the database if the database is deployed on a remote server. The root cause is that both the frontend and backend app run in local mode (can only be accessed from the same machine), therefore all external access will be blocked. This PR fixes these bugs.

This PR also fixes some related SQL logic bugs. The original SQL logic fails to get the data under some corner cases.

Linked issue(s)/Pull request(s)

Type of Change

  • Non-breaking bug fix
  • Breaking bug fix
  • New feature
  • Test
  • Doc update
  • Docker update

Related Component

  • Simulation toolkit
  • RL toolkit
  • Distributed toolkit
  • Geo vis

Has Been Tested

  • OS:
    • Windows
    • Mac OS
    • Linux
  • Python version:
    • 3.6
    • 3.7
  • Key information snapshot(s):

Needs Follow Up Actions

  • New release package
  • New docker image

Checklist

  • Add/update the related comments
  • Add/update the related tests
  • Add/update the related documentations
  • Update the dependent downstream modules usage

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants