Skip to content

Added SignatureHelpContext#805

Closed
KamasamaK wants to merge 1 commit intomicrosoft:gh-pagesfrom
KamasamaK:gh-pages-signaturehelpcontext
Closed

Added SignatureHelpContext#805
KamasamaK wants to merge 1 commit intomicrosoft:gh-pagesfrom
KamasamaK:gh-pages-signaturehelpcontext

Conversation

@KamasamaK
Copy link
Contributor

This adds SignatureHelpContext to the textDocument/signatureHelp request.

Fixes #561

Fixes #797

@KamasamaK
Copy link
Contributor Author

Note that I changed SignatureHelpTriggerKind.Invoke from VS Code to Invoked so it is consistent with CompletionTriggerKind, which was also changed from VS Code.

Also, sorry I included some unrelated syntax fixes that I noticed while doing this.

@dbaeumer dbaeumer added this to the 3.15 milestone Aug 12, 2019
@dbaeumer
Copy link
Member

dbaeumer commented Sep 9, 2019

@dbaeumer dbaeumer closed this Sep 9, 2019
@dbaeumer
Copy link
Member

dbaeumer commented Sep 9, 2019

Add implementation to client as well.

@KamasamaK KamasamaK deleted the gh-pages-signaturehelpcontext branch April 25, 2022 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants