Hi @Marwes, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@Marwes it does not in the 2.0 version of the protocol anymore. It instead has a property textDocument: TextDocumentItem; which refers to the text document and has additional properties.

Sorry, now you got me confused. Is DidOpenTextDocumentParams supposed to extend TextDocumentIdentifier (which gives it an uri field directly in addition to the one in textDocument) but that is not implemented yet in https://github.com/Microsoft/vscode-languageserver-node ?

@Marwes no, it was that way in the 1.0 version of the protocol (which is available here: https://github.com/Microsoft/language-server-protocol/blob/master/versions/protocol-1-x.md). In the 2.0 version we cleaned this up and steps away from 'inlining' parameters.

In that case, should my PR not be a fix since it removes extends TextDocumentIdentifier ?

@Marwes I apologoize a lot. I misread the diff. Makes perfect sense. And thank you for not giving up :-).

Hi @Marwes, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

No problem. Just happy to be of some help, the protocol made it really simple to provide completion for my own little language :).