Change "utf8" to "utf-8" with a hyphen#199
Merged
dbaeumer merged 2 commits intomicrosoft:masterfrom Apr 11, 2017
ljw1004:master
Merged
Change "utf8" to "utf-8" with a hyphen#199dbaeumer merged 2 commits intomicrosoft:masterfrom ljw1004:master
dbaeumer merged 2 commits intomicrosoft:masterfrom
ljw1004:master
Conversation
The charset name is "utf-8" with a hyphen. I think that "utf8" without a hyphen doesn't even exist in the wild. https://tools.ietf.org/html/rfc3629 - section 8 https://tools.ietf.org/html/rfc5987 - section 3.2.1
|
This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request. |
Member
|
Agree. It is the constant usually used in node. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The charset name is "utf-8" with a hyphen. I think that "utf8" without a hyphen doesn't even exist in the wild.
https://tools.ietf.org/html/rfc3629 - section 8
https://tools.ietf.org/html/rfc5987 - section 3.2.1