Skip to content

Conversation

@MariaSolOs
Copy link
Contributor

@MariaSolOs MariaSolOs commented Feb 1, 2024

Adds the definition of StringValue, which is currently used in the metamodel by inline completions.

@MariaSolOs
Copy link
Contributor Author

@dbaeumer I think we should remove the insertTextFormat property from InlineCompletionItem:

/**
* The format of the insert text. The format applies to the `insertText`.
* If omitted, defaults to `InsertTextFormat.PlainText`.
*/
insertTextFormat?: InsertTextFormat;

Why?

@dbaeumer dbaeumer enabled auto-merge (squash) February 2, 2024 08:19
@vscodenpa vscodenpa added this to the February 2024 milestone Feb 2, 2024
@dbaeumer dbaeumer merged commit 0a0ccb4 into microsoft:gh-pages Feb 2, 2024
@MariaSolOs MariaSolOs deleted the string-values branch February 2, 2024 16:22
@dbaeumer
Copy link
Member

dbaeumer commented Feb 5, 2024

@MariaSolOs makes perfekt sense to remove insertTextFormat

@MariaSolOs
Copy link
Contributor Author

@MariaSolOs makes perfekt sense to remove insertTextFormat

Alright, doing that here: #1894 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants