[Log] Support multiple CLI loggers#227
Merged
jiasli merged 2 commits intomicrosoft:masterfrom Dec 29, 2020
Merged
Conversation
evelyn-ys
reviewed
Dec 28, 2020
Comment on lines
+143
to
145
| if root_logger.handlers: | ||
| # handlers already configured | ||
| return |
Contributor
There was a problem hiding this comment.
Is it enough when root_logger.handlers is set?
In previous code, both root_logger.handlers and cli_logger.handlers are checked.
Should we check all cli_logger.handlers for cli_logger in cli_loggers?
Member
Author
There was a problem hiding this comment.
Note really necessary, as root logger and cli logger are always set at the same time.
Lines 171 to 177 in 30592e0
evelyn-ys
approved these changes
Dec 28, 2020
jiasli
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redo #221
cli_logger_nameofknack.log.CLILogging.__init__so that no breaking change is made.knack.log.cli_logger_nameslist.