Skip to content

Kiota Dotnet Mono repo migration - #262

Merged
Andrew Omondi (andrueastman) merged 18 commits into
mainfrom
andrueastman/monoRepoMigration
Jul 8, 2024
Merged

Andrew Omondi (andrueastman) merged 18 commits into
mainfrom
andrueastman/monoRepoMigration

Conversation

@andrueastman

@andrueastman Andrew Omondi (andrueastman) commented Jul 5, 2024 •

Copy link
Copy Markdown
Contributor

Fixes #238

In Summary changes include

  • Restructure csproj file to be simpler to eliminate repeated configs (which are now held in Directory.Build.props)
  • Update version stratey to be common accross libs (pulled from Directory.Build.props)
  • Updates CI and release pipelines/scripts
  • Moves sources of other libraries to be held in one project solution (Microsoft.Kiota) as below
 └─Microsoft.Kiota.sln
 └─src
    └─abstractions
    └─authentication
       └─azure
    └─http
       └─httpClient
    └─serialization
       └─json
       └─form
       └─text
       └─multipart
 └─tests
    └─abstractions
    └─authentication
       └─azure
    └─http
       └─httpClient
    └─serialization
       └─json
       └─form
       └─text
       └─multipart

CI/Validation

Notes
To separate concerns, sources are migrated as is. Resolving any issues with the source would ideally be done separately.

@baywet Vincent Biret (baywet) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good progress, I left a couple of comments to help. Also:

  • dependabot configuration needs to be updated.
  • repo url in csproj needs to be changed to kiota-dotnet (I'll rename the repo after we merge)

Comment thread src/abstractions/README.md Resolved
Comment thread src/authentication/azure/README.md Resolved
Comment thread src/http/httpClient/README.md Resolved
Comment thread src/serialization/form/README.md Resolved
Comment thread src/serialization/json/README.md Resolved
Comment thread src/serialization/multipart/README.md Resolved
Comment thread src/serialization/text/README.md Resolved
@andrueastman
Andrew Omondi (andrueastman) force-pushed the andrueastman/monoRepoMigration branch from 7083ad8 to fc11a4f Compare July 8, 2024 08:34
@andrueastman

Andrew Omondi (andrueastman) commented Jul 8, 2024 •

Copy link
Copy Markdown
Contributor Author

Vincent Biret (@baywet) With regards to the dependabot configs, I notice the config is already set to scan the repository root(this should pick up any csproj files). Any chance you had different thoughts here with regards to updating this?

Comment thread Directory.Build.props
<!-- Common default project properties for ALL projects-->
<PropertyGroup>
<VersionPrefix>1.9.8</VersionPrefix>
<VersionSuffix>preview</VersionSuffix>

@andrueastman Andrew Omondi (andrueastman) Jul 8, 2024 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: The preview suffix is intentional for now to double check the release process end to end without breaking with a production version with regards to sourcelink, signing and all packages getting published. Will empty the value in a separate PR once previews are confirmed to be valid.
Run here already validates proper signing but best to be sure.

@andrueastman Andrew Omondi (andrueastman) changed the title [WIP] Kiota Dotnet Mono repo migration Kiota Dotnet Mono repo migration Jul 8, 2024
@andrueastman
Andrew Omondi (andrueastman) marked this pull request as ready for review July 8, 2024 10:15
@andrueastman
Andrew Omondi (andrueastman) requested a review from a team as a code owner July 8, 2024 10:15
Comment thread .azure-pipelines/ci-build.yml Resolved
Comment thread README.md Resolved
Comment thread src/abstractions/Changelog-old.md Resolved
Co-authored-by: Vincent Biret <[email protected]>
@sonarqubecloud

sonarqubecloud Bot commented Jul 8, 2024

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots
70.5% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Group kiota dotnet repositories

2 participants