Repository navigation
[Python] Remove deprecated type aliases from generated code for python 3.9+. - #5974
Merged
Merged
Conversation
Contributor
Author
|
Sample generation at microsoft/kiota-python#434 |
3 tasks done
Contributor
Author
|
Depends on release of microsoft/kiota-python#433 |
Andrew Omondi (andrueastman)
changed the title
Vincent Biret (baywet)
previously approved these changes
Jan 9, 2025
Vincent Biret (baywet)
left a comment
Vincent Biret (baywet)
left a comment
Member
There was a problem hiding this comment.
mostly good with those changes. I did leave a comment on the test generation PR. I think a regression was introduced some time ago. Not sure whether we want to address it now or as part of a separate PR.
Contributor
Author
Addressed in the PR with this change 98971c7 |
Andrew Omondi (andrueastman)
enabled auto-merge
January 13, 2025 08:12
Vincent Biret (baywet)
approved these changes
Jan 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial of microsoft/kiota-python#349
Related to microsoft/kiota-python#433
Drops deprecated type hints used in python 3.9+.