Skip to content

Replace NNBSP with regular space for date-time formats on English locales#134

Merged
rp9-next merged 3 commits intomasterfrom
user/pandeyrah/replaceNNBSPWithSpace
Aug 7, 2023
Merged

Replace NNBSP with regular space for date-time formats on English locales#134
rp9-next merged 3 commits intomasterfrom
user/pandeyrah/replaceNNBSPWithSpace

Conversation

@rp9-next
Copy link
Collaborator

@rp9-next rp9-next commented Aug 1, 2023

The change adds overrides for replacing NNBSP with ASCII space.
It also restores official date formats for en_CA
This would restore earlier behavior for date time formatting for many English locales.

Summary

PR Checklist

  • I have verified that my change is specific to this fork and cannot be made upstream.
  • I am making a maintenance related change.
  • I am making a change that is related to usage internal to Microsoft.
  • I am making a change that is related to the Windows OS build of ICU.
  • CLA signed. If not, please see here to sign the CLA.

Detailed Description

@rp9-next rp9-next marked this pull request as ready for review August 4, 2023 12:49
@rp9-next rp9-next self-assigned this Aug 7, 2023
@rp9-next rp9-next merged commit 0351e5d into master Aug 7, 2023
@rp9-next rp9-next deleted the user/pandeyrah/replaceNNBSPWithSpace branch August 7, 2023 06:15
@jefgen
Copy link
Member

jefgen commented Aug 7, 2023

Thanks @rp9-next! 😊

rp9-next added a commit that referenced this pull request Oct 12, 2023
…ales (#134)

* Replace NNBSP with regular space for date-time formats on English locales and fix test cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants