refactor(coding-standards): align agent and prompt folder names to collection identifier by katriendg · Pull Request #1210 · microsoft/hve-core

katriendg · 2026-03-26T10:59:00Z

Renamed the code-review folder to coding-standards under both .github/agents/ and .github/prompts/, aligning these folder names with the collection identifier used in coding-standards.collection.yml. Updated all downstream references across collection manifests, plugin outputs, VS Code workspace settings, and installer skill templates.

Description

The code-review folder name was a holdover from when this collection contained only code review artifacts. As it expanded to include coding standards instructions across multiple languages and frameworks, the folder name no longer matched its collection identity. This rename brings folder structure into alignment with the coding-standards collection name.

Folder Rename

Moved the Functional Code Review agent and prompt from code-review/ to coding-standards/ under their respective .github/ directories. Updated the agent frontmatter name field from kebab-case to title-case (Functional Code Review) and updated the prompt's agent reference and body text to match.

Renamed .github/agents/code-review/ → .github/agents/coding-standards/
Renamed .github/prompts/code-review/ → .github/prompts/coding-standards/

Collection and Plugin Updates

Propagated the path change through all manifests and generated outputs.

Updated item paths in coding-standards.collection.yml and hve-core-all.collection.yml
Updated agents and commands arrays in plugins/coding-standards/.github/plugin/plugin.json and plugins/hve-core-all/.github/plugin/plugin.json
Rotated symlinks under plugins/coding-standards/ and plugins/hve-core-all/ from code-review/ to coding-standards/

Installer and Workspace Settings

Updated path references in the hve-core-installer skill and local workspace settings.

Updated four code-review → coding-standards path references in .github/skills/installer/hve-core-installer/SKILL.md (VS Code settings templates and devcontainer.json examples)
Added coding-standards entries to .vscode/settings.json under chat.agentFilesLocations and chat.promptFilesLocations

Plugin Regeneration Side Effects

Running npm run plugin:generate also produced new symlinks for skills that were previously registered in collections but had not yet been generated:

plugins/gitlab/skills/gitlab/gitlab
plugins/hve-core-all/skills/gitlab/gitlab
plugins/hve-core-all/skills/jira/jira
plugins/jira/skills/jira/jira

Related Issue(s)

Closes #1208

Type of Change

Code & Documentation:

Bug fix (non-breaking change fixing an issue)
New feature (non-breaking change adding functionality)
Breaking change (fix or feature causing existing functionality to change)
Documentation update

Infrastructure & Configuration:

AI Artifacts:

Reviewed contribution with prompt-builder agent and addressed all feedback
Copilot instructions (.github/instructions/*.instructions.md)
Copilot prompt (.github/prompts/*.prompt.md)
Copilot agent (.github/agents/*.agent.md)
Copilot skill (.github/skills/*/SKILL.md)

Note for AI Artifact Contributors:

Agents: Research, indexing/referencing other project (using standard VS Code GitHub Copilot/MCP tools), planning, and general implementation agents likely already exist. Review .github/agents/ before creating new ones.

Skills: Must include both bash and PowerShell scripts. See Skills.

Model Versions: Only contributions targeting the latest Anthropic and OpenAI models will be accepted. Older model versions (e.g., GPT-3.5, Claude 3) will be rejected.

See Agents Not Accepted and Model Version Requirements.

Other:

Script/automation (.ps1, .sh, .py)
Other (please describe):

Sample Prompts (for AI Artifact Contributions)

User Request:

Execution Flow:

Output Artifacts:

Success Indicators:

Testing

Ran npm run lint:md — validates markdown formatting across all changed files.
Ran npm run spell-check — validates spelling across changed files.
Ran npm run lint:frontmatter — validates YAML frontmatter in renamed agent and prompt files.
Ran npm run validate:skills — validates skill structure for the modified installer skill.
Ran npm run lint:md-links — validates markdown link integrity.
Ran npm run lint:ps — PowerShell analysis.
Ran npm run plugin:generate — confirms plugin outputs are fresh and match collection manifests.
Verified new paths exist and old paths are fully removed.
Confirmed no remaining code-review folder references in .github/agents/, .github/prompts/, collections/, or .vscode/.
Manual testing was not performed.

Checklist

Required Checks

Documentation is updated (if applicable)
Files follow existing naming conventions
Changes are backwards compatible (if applicable) (N/A — this is an intentional breaking change aligning folder names to collection identifiers)
Tests added for new functionality (if applicable) (N/A — no new functionality added)

AI Artifact Contributions

Used /prompt-analyze to review contribution
Addressed all feedback from prompt-builder review
Verified contribution follows common standards and type-specific requirements

Required Automated Checks

The following validation commands must pass before merging:

Markdown linting: npm run lint:md
Spell checking: npm run spell-check
Frontmatter validation: npm run lint:frontmatter
Skill structure validation: npm run validate:skills
Link validation: npm run lint:md-links
PowerShell analysis: npm run lint:ps
Plugin freshness: npm run plugin:generate

Security Considerations

This PR does not contain any sensitive or NDA information
Any new dependencies have been reviewed for security issues (N/A — no new dependencies)
Security-related scripts follow the principle of least privilege (N/A — no security scripts modified)

Additional Notes

The code-review → coding-standards rename is a breaking change for users who reference the old folder paths in their VS Code settings or custom configurations. Users of the hve-core-installer skill will get the updated paths automatically on their next installation run. Users with manually configured paths need to update code-review to coding-standards in their chat.agentFilesLocations and chat.promptFilesLocations settings.

- rename .github/agents/code-review/ and .github/prompts/code-review/ to coding-standards/ - update collection YAML paths in coding-standards and hve-core-all manifests - update installer SKILL.md settings templates with new folder paths - regenerate plugin outputsadd coding-standards to VS Code settings 📦 - Generated by Copilot

…names

codecov-commenter · 2026-03-26T11:01:26Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.64%. Comparing base (6ac66a6) to head (4838e3c).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1210      +/-   ##
==========================================
- Coverage   87.65%   87.64%   -0.02%     
==========================================
  Files          61       61              
  Lines        9315     9315              
==========================================
- Hits         8165     8164       -1     
- Misses       1150     1151       +1

Flag	Coverage Δ
pester	`85.30% <ø> (-0.02%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

auyidi1 · 2026-03-27T23:21:45Z

Nt: Missing newline at end of file in two files
settings.json L70: The diff shows } No newline at end of file — the trailing newline was removed from settings.json. This is a regression; the file previously had a newline.

plugin.json (coding-standards) L11: } No newline at end of file — plugins/coding-standards/.github/plugin/plugin.json also lacks a trailing newline. Most editors and linters flag this. POSIX text files require a final newline. Both files should be fixed.

katriendg · 2026-03-30T07:22:06Z

@auyidi1 good point on the trailing new line, my editor was automatically removing it so I also added a line about this in the settings.json now.

## Pre-Release 3.3.27 ### ✨ Features - standardize pytest-mock as Python mocking framework (#1170) - add Jira backlog workflows and Jira/GitLab skills (#978) - add centralized version bump script and supply-chain attestation (#1183) ### 🐛 Bug Fixes - sync package-lock.json after pre-release version bump (#1236) - separate mermaid node declarations and add dynamic diagram generation with tests (#1215) - replace anchor links in meeting-analyst with bold text references (#1201) - remove recursive symlinks in jira and gitlab skill directories (#1233) - validate-installation scripts now check .github/skills directory (#1010) (#1206) - resolve npm audit vulnerabilities via dependency overrides (#1200) - add post-release triggers to scorecard workflow (#1186) - add missing .md extensions to relative links in agent documentation (#1180) ### ♻️ Refactoring - align agent and prompt folder names to collection identifier (#1210) ### 🔧 Maintenance - bump pygments from 2.19.2 to 2.20.0 in /.github/skills/gitlab/gitlab (#1234) - bump path-to-regexp from 0.1.12 to 0.1.13 in /docs/docusaurus (#1226) - bump the github-actions group with 4 updates (#1231) - add missing folders and alphabetize location lists (#1193) - bump brace-expansion (#1224) - bump handlebars from 4.7.8 to 4.7.9 in /docs/docusaurus (#1217) - bump brace-expansion from 5.0.3 to 5.0.5 in /docs/docusaurus (#1213) - pre-release 3.3.10 (#1187) - bump markdownlint-cli2 from 0.21.0 to 0.22.0 in the npm-dependencies group (#1175) - bump the github-actions group with 3 updates (#1176) - pre-release 3.3.1 (#1165) --- *Managed automatically by pre-release workflow.* Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

## Pre-Release 3.3.41 ### ✨ Features - add agentic workflows for automated issue triage, implementation, PR review, dependency review, and doc-staleness detection (#1219) - consolidate package-lock.json version sync into Update-VersionFiles.ps1 (#1240) - add standards code review agent and full review orchestrator (#1174) - standardize pytest-mock as Python mocking framework (#1170) - add Jira backlog workflows and Jira/GitLab skills (#978) - add centralized version bump script and supply-chain attestation (#1183) ### 🐛 Bug Fixes - replace invalid bare tool names with official tool identifiers (#1198) - fix broken links and remove orphaned reference in code review docs (#1257) - exclude Python env dirs from skill validation warnings (#1255) - pin happy-dom and serialize-javascript to resolve Dependabot vulnerabilities (#1253) - remove Mermaid diagram and add missing collection cards (#1247) - disable MCP servers by default to prevent token limit errors (#1144) - sync package-lock.json after pre-release version bump (#1236) - separate mermaid node declarations and add dynamic diagram generation with tests (#1215) - replace anchor links in meeting-analyst with bold text references (#1201) - remove recursive symlinks in jira and gitlab skill directories (#1233) - validate-installation scripts now check .github/skills directory (#1010) (#1206) - resolve npm audit vulnerabilities via dependency overrides (#1200) - add post-release triggers to scorecard workflow (#1186) - add missing .md extensions to relative links in agent documentation (#1180) ### 📚 Documentation - CLI getting-started: clarify plugin install commands as alternatives (-all vs base) (#1251) ### ♻️ Refactoring - align agent and prompt folder names to collection identifier (#1210) ### 🔧 Maintenance - streamline RAI Planner phase structure and documentation (#1273) - bump happy-dom from 20.8.8 to 20.8.9 in /docs/docusaurus (#1237) - pre-release 3.3.27 (#1191) - bump pygments from 2.19.2 to 2.20.0 in /.github/skills/gitlab/gitlab (#1234) - bump path-to-regexp from 0.1.12 to 0.1.13 in /docs/docusaurus (#1226) - bump the github-actions group with 4 updates (#1231) - add missing folders and alphabetize location lists (#1193) - bump brace-expansion (#1224) - bump handlebars from 4.7.8 to 4.7.9 in /docs/docusaurus (#1217) - bump brace-expansion from 5.0.3 to 5.0.5 in /docs/docusaurus (#1213) - pre-release 3.3.10 (#1187) - bump markdownlint-cli2 from 0.21.0 to 0.22.0 in the npm-dependencies group (#1175) - bump the github-actions group with 3 updates (#1176) - pre-release 3.3.1 (#1165) --- *Managed automatically by pre-release workflow.* Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

## Pre-Release 3.3.101 ### ✨ Features - add removed maturity tier and retire owasp-docker (#1444) - add evaluation dataset creator (#1279) - align RAI planner with guide, remove scoring, improve UX (#1287) - add PSGallery staleness check and BOM cleanup (#1379) - ISA-95 network planner agent (#1177) - auto-generate collection.md with maturity filtering (#1316) - add folder-consistency check and standardize WARN outp… (#1350) - add synth-data-generate prompt to data-science collection (#1419) - add canonical deck workflow and customer-card rendering for design thinking (#1413) - add Figma MCP integration for DT artifact export (#1222) - introduce `owasp-docker` (#1245) - replace hve-core-specific references with portable discovery-based language (#1335) - introduce `owasp-cicd` (#1246) - add secure-by-design knowledge skill (#1223) - introduce `owasp-infrastructure` (#1244) - introduce `owasp-mcp` (#1207) - add OutputPath parameter to Invoke-LinkLanguageCheck.ps1 (#1229) - add -OutputPath parameter to Validate-SkillStructure.ps1 (#1225) - add maintainer-only skip-review label guard (#1293) - add extension collections overview and integrate into getting started flow (#950) - add agentic workflows for automated issue triage, implementation, PR review, dependency review, and doc-staleness detection (#1219) - consolidate package-lock.json version sync into Update-VersionFiles.ps1 (#1240) - add standards code review agent and full review orchestrator (#1174) - standardize pytest-mock as Python mocking framework (#1170) - add Jira backlog workflows and Jira/GitLab skills (#978) - add centralized version bump script and supply-chain attestation (#1183) ### 🐛 Bug Fixes - pin PowerShell-Yaml to 0.4.7 across all install sites (#1378) - close fork-PR/workflow-file-PR secret-strip gap and normalize upload-artifact version (#1421) - replace stream-based lookahead with array indexing in list-changed-files.sh (#1376) - centralize ISO 8601 timestamp regex in CIHelpers (#1343) - update stale documentation date in release-process.md (#1363) - pin basic-ftp to 5.3.0 to resolve GHSA-rp42-5vxx-qpwr (#1374) - add bot filter to dependency PR review workflow (#1362) - resolve pip-audit findings in powerpoint, gitlab, and jira skill lock files (#1360) - standardize Timestamp JSON key casing across all lint result files (#1314) - add synchronize trigger to PR Review workflow (#1323) - standardize timestamp in Validate-SkillStructure.ps1 to use Get-StandardTimestamp (#1280) - add parallel subagent dispatch and structured JSON contracts to code-review-full (#1304) - standardize timestamp in SecurityHelpers.psm1 to use Get-StandardTimestamp (#1284) - standardize timestamps in Test-DependencyPinning.ps1 and SecurityClasses.psm1 (#1282) - derive collection artifact counts from YAML at build time (#1275) - standardize timestamp in FrontmatterValidation.psm1 to use Get-StandardTimestamp (#1285) - standardize timestamp in Markdown-Link-Check.ps1 to use Get-StandardTimestamp (#1283) - escape hyphens in Mermaid diagram on Collections page (#1262) - add summary timestamp to PSScriptAnalyzer output (#1211) - fix plugin compatibility and robustness for coding-standards code review agents (#1289) - standardize timestamp in Test-CopyrightHeaders.ps1 to use Get-StandardTimestamp (#1278) - standardize timestamp in Invoke-YamlLint.ps1 to use Get-StandardTimestamp (#1270) - standardize timestamp in Invoke-LinkLanguageCheck.ps1 to use Get-StandardTimestamp (#1264) - fix dependency-review path filters and sparse-checkout cone mode (#1259) - replace invalid bare tool names with official tool identifiers (#1198) - fix broken links and remove orphaned reference in code review docs (#1257) - exclude Python env dirs from skill validation warnings (#1255) - pin happy-dom and serialize-javascript to resolve Dependabot vulnerabilities (#1253) - remove Mermaid diagram and add missing collection cards (#1247) - disable MCP servers by default to prevent token limit errors (#1144) - sync package-lock.json after pre-release version bump (#1236) - separate mermaid node declarations and add dynamic diagram generation with tests (#1215) - replace anchor links in meeting-analyst with bold text references (#1201) - remove recursive symlinks in jira and gitlab skill directories (#1233) - validate-installation scripts now check .github/skills directory (#1010) (#1206) - resolve npm audit vulnerabilities via dependency overrides (#1200) - add post-release triggers to scorecard workflow (#1186) - add missing .md extensions to relative links in agent documentation (#1180) ### 📚 Documentation - broaden Security Review description beyond OWASP (#1385) - document maintainer advisory mode and skip-review label guard (#1386) - document ExcludePaths/OutputPath for Invoke-LinkLanguageCheck (#1383) - CLI getting-started: clarify plugin install commands as alternatives (-all vs base) (#1251) ### ♻️ Refactoring - align agent and prompt folder names to collection identifier (#1210) ### 🔧 Maintenance - pin PSScriptAnalyzer to 1.25.0 and sync stale workflow version comments (#1389) - bump lxml from 6.0.2 to 6.1.0 in /.github/skills/experimental/powerpoint (#1424) - bump @vscode/vsce from 3.7.1 to 3.9.1 in the npm-dependencies group (#1390) - bump the github-actions group across 1 directory with 7 updates (#1391) - bump follow-redirects from 1.15.11 to 1.16.0 in /docs/docusaurus (#1356) - upgrade Node.js from 20 to 24 and bump cspell to v10 (#1353) - bump basic-ftp from 5.2.0 to 5.2.1 (#1324) - update github/gh-aw-actions requirement to 536ea1bad8c6715d098a9dc1afea8d403733acfe in the github-actions group across 1 directory (#1298) - update security instruction attributions and compliance (#1294) - bump the npm-dependencies group with 2 updates (#1297) - pre-release 3.3.41 (#1252) - streamline RAI Planner phase structure and documentation (#1273) - bump happy-dom from 20.8.8 to 20.8.9 in /docs/docusaurus (#1237) - pre-release 3.3.27 (#1191) - bump pygments from 2.19.2 to 2.20.0 in /.github/skills/gitlab/gitlab (#1234) - bump path-to-regexp from 0.1.12 to 0.1.13 in /docs/docusaurus (#1226) - bump the github-actions group with 4 updates (#1231) - add missing folders and alphabetize location lists (#1193) - bump brace-expansion (#1224) - bump handlebars from 4.7.8 to 4.7.9 in /docs/docusaurus (#1217) - bump brace-expansion from 5.0.3 to 5.0.5 in /docs/docusaurus (#1213) - pre-release 3.3.10 (#1187) - bump markdownlint-cli2 from 0.21.0 to 0.22.0 in the npm-dependencies group (#1175) - bump the github-actions group with 3 updates (#1176) - pre-release 3.3.1 (#1165) --- *Managed automatically by pre-release workflow.* Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

katriendg added 2 commits March 26, 2026 11:40

Merge remote-tracking branch 'origin/main' into refactor/1208-folder-…

f8c1afb

…names

katriendg requested a review from a team as a code owner March 26, 2026 10:59

WilliamBerryiii approved these changes Mar 26, 2026

View reviewed changes

bindsi approved these changes Mar 27, 2026

View reviewed changes

Merge branch 'main' into refactor/1208-folder-names

20aa015

auyidi1 approved these changes Mar 27, 2026

View reviewed changes

Comment thread .vscode/settings.json

chore: add files.insertFinalNewLine for json

a472e01

katriendg requested a review from bindsi March 30, 2026 07:22

Merge branch 'main' into refactor/1208-folder-names

4838e3c

bindsi approved these changes Mar 30, 2026

View reviewed changes

katriendg merged commit 3b1d408 into main Mar 30, 2026
40 checks passed

This was referenced Mar 30, 2026

chore(main): pre-release 3.3.27 #1191

Merged

chore(main): release hve-core 3.4.0 #1184

Open

hve-core-release-please Bot mentioned this pull request Mar 31, 2026

chore(main): pre-release 3.3.41 #1252

Merged

hve-core-release-please Bot mentioned this pull request Apr 2, 2026

chore(main): pre-release 3.3.101 #1274

Merged

hve-core-release-please Bot mentioned this pull request Apr 27, 2026

chore(main): pre-release 3.3.111 #1476

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(coding-standards): align agent and prompt folder names to collection identifier#1210

refactor(coding-standards): align agent and prompt folder names to collection identifier#1210
katriendg merged 5 commits intomainfrom
refactor/1208-folder-names

katriendg commented Mar 26, 2026

Uh oh!

codecov-commenter commented Mar 26, 2026 •

edited

Loading

Uh oh!

auyidi1 commented Mar 27, 2026

Uh oh!

Uh oh!

katriendg commented Mar 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

katriendg commented Mar 26, 2026

Description

Folder Rename

Collection and Plugin Updates

Installer and Workspace Settings

Plugin Regeneration Side Effects

Related Issue(s)

Type of Change

Sample Prompts (for AI Artifact Contributions)

Testing

Checklist

Required Checks

AI Artifact Contributions

Required Automated Checks

Security Considerations

Additional Notes

Uh oh!

codecov-commenter commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

auyidi1 commented Mar 27, 2026

Uh oh!

Uh oh!

katriendg commented Mar 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov-commenter commented Mar 26, 2026 •

edited

Loading