Summary
The Test-DependencyPinning.ps1 script incorrectly flags package.json metadata fields (name, displayName, version, description, publisher, path) as unpinned npm dependencies.
Current Behavior
Running npm run dependency-pinning produces 169 violations, but most are false positives:
{
"File": "extension\\package.json",
"Line": 2,
"Type": "npm",
"Name": "name",
"Version": "hve-core",
"Description": "Unpinned dependency: NPM dependencies in package.json"
}
The script's regex pattern matches any "key": "value" pair in package.json rather than specifically targeting the dependencies and devDependencies sections.
Expected Behavior
The script should only flag actual npm dependencies in:
dependencies
devDependencies
peerDependencies
optionalDependencies
Acceptance Criteria
References
Summary
The
Test-DependencyPinning.ps1script incorrectly flags package.json metadata fields (name, displayName, version, description, publisher, path) as unpinned npm dependencies.Current Behavior
Running
npm run dependency-pinningproduces 169 violations, but most are false positives:{ "File": "extension\\package.json", "Line": 2, "Type": "npm", "Name": "name", "Version": "hve-core", "Description": "Unpinned dependency: NPM dependencies in package.json" }The script's regex pattern matches any
"key": "value"pair in package.json rather than specifically targeting thedependenciesanddevDependenciessections.Expected Behavior
The script should only flag actual npm dependencies in:
dependenciesdevDependenciespeerDependenciesoptionalDependenciesAcceptance Criteria
Test-DependencyPinning.ps1to parse package.json structure and only check dependency sectionsReferences